Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine naming and conventions around special RPCs #71

Closed
jrschumacher opened this issue Jan 23, 2024 · 2 comments
Closed

Determine naming and conventions around special RPCs #71

jrschumacher opened this issue Jan 23, 2024 · 2 comments
Labels
adr Architecture Decision Records pertaining to OpenTDF comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) spike Spike tickets which are research based and timeboxed
Milestone
Finalize protos a...

Comments

@jrschumacher
Copy link
Member

jrschumacher commented Jan 23, 2024 •
edited

During the conversations around #63 and #62 we determined that we might need special RPCs to support destructive commands and to avoid adding destructive side effects into the basic CRUD RPCs.

Acceptance Criteria

  • determine naming of these destructive RPCs which will be used as release valves for decisions that were made early on
  • determine code convention as we build these RPCs into our services

Decision

There will be a single UnsafeService under Policy which will have all the unsafe operations. This will provide a more consolidated experience for devs and admins as well as supporting better AuthZ support via middleware.
@jrschumacher
Copy link
Member Author

React has used the Unsafe prefix and has recently updated these to a more verbose language dangerouslySetInnerHTML

@jrschumacher jrschumacher added the spike Spike tickets which are research based and timeboxed label Jan 23, 2024
@jakedoublev jakedoublev mentioned this issue Jan 31, 2024
Closed
@jrschumacher
Copy link
Member Author

Will unblock #115

@jrschumacher jrschumacher added the comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) label Feb 2, 2024
@jakedoublev jakedoublev mentioned this issue Feb 13, 2024
Closed
@jrschumacher jrschumacher added the adr Architecture Decision Records pertaining to OpenTDF label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adr Architecture Decision Records pertaining to OpenTDF comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) spike Spike tickets which are research based and timeboxed
Projects
None yet
Milestone
Finalize protos and SDK
Development

No branches or pull requests
2 participants
@jrschumacher @dmihalcik-virtru