Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-queue: golangci-lint doesn't filter to only new issues #281

Closed
dmihalcik-virtru opened this issue Feb 29, 2024 · 0 comments
Closed
Labels
bug Something isn't working comp:ci Github Actions Work triaged

Comments

@dmihalcik-virtru
Copy link
Member

dmihalcik-virtru commented Feb 29, 2024

See: golangci/golangci-lint-action#956

The action's only-new-issues feature does not handle the merge_group event, falling back to list all issues for merge queue runs.

Sample run: https://github.com/opentdf/platform/actions/runs/8101523724/job/22141898894

Work around: Use the command line --new-from-rev=main instead, on merge queue events. This should give (about) all changes between main and the current request. Alternative: --new-from-rev=HEAD~1 or I think just --new? Which would give diffs against the most earlier item currently in the queue, but that might be less stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:ci Github Actions Work triaged
Projects
None yet
Development

No branches or pull requests

2 participants