Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy API: fixtures should employ flattened selectors instead of jq expressions #646

Closed
jakedoublev opened this issue Apr 23, 2024 · 0 comments · Fixed by #665
Closed

Policy API: fixtures should employ flattened selectors instead of jq expressions #646

jakedoublev opened this issue Apr 23, 2024 · 0 comments · Fixed by #665
Assignees
@jakedoublev
Labels
comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry)

Comments

@jakedoublev
Copy link
Contributor

Background

As a result of the accepted ADR to employ flattening of an Entity Representation into known fields and values, the policy fixtures should exemplify the flattened key selectors instead of jq syntax when provisioning the local development database and unit test suite.

Acceptance Criteria

  1. the policy fixtures are updated to remove jq expression syntax with flattened syntax examples in their place
  2. any relevant unit tests are checked and updated if they mention jq expressions
@jakedoublev jakedoublev mentioned this issue Apr 23, 2024
Open
@jakedoublev jakedoublev added comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) labels Apr 23, 2024
@jakedoublev jakedoublev self-assigned this Apr 24, 2024
@jakedoublev jakedoublev mentioned this issue Apr 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@jakedoublev
chore(policy): remove jq references from protos, test fixtures, and t…
06e926d 
…ests (#665)

Caused by #610

Closes #646
tech-guru42 added a commit to tech-guru42/TDF that referenced this issue Jun 3, 2024
@tech-guru42
chore(policy): remove jq references from protos, test fixtures, and t…
aab85a8 
…ests (#665)

Caused by opentdf/platform#610

Closes opentdf/platform#646
passion-127 added a commit to passion-127/TDF that referenced this issue Jun 6, 2024
@passion-127
chore(policy): remove jq references from protos, test fixtures, and t…
dfb1341 
…ests (#665)

Caused by opentdf/platform#610

Closes opentdf/platform#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakedoublev jakedoublev

Labels
comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(policy): remove jq references from protos, test fixtures, and tests opentdf/platform
2 participants
@jrschumacher @jakedoublev