-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add assertion to tdf - phase1 #575
base: main
Are you sure you want to change the base?
Conversation
) | ||
|
||
func (a AssertionType) String() string { | ||
return [...]string{"Handling", "Base"}[a] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spread these out so we have clean blames for new enum values
return [...]string{"Handling", "Base"}[a] | |
return [...]string{ | |
"Handling", | |
"Base", | |
}[a] |
sdk/assertion.go
Outdated
func (s StatementType) String() string { | ||
return [...]string{"ReferenceStatement", "StructuredStatement", "StringStatement", | ||
"Base64BinaryStatement", "XMLBase64", "HandlingStatement", "String"}[s] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (s StatementType) String() string { | |
return [...]string{"ReferenceStatement", "StructuredStatement", "StringStatement", | |
"Base64BinaryStatement", "XMLBase64", "HandlingStatement", "String"}[s] | |
func (s StatementType) String() string { | |
return [...]string{ | |
"ReferenceStatement", | |
"StructuredStatement", | |
"StringStatement", | |
"Base64BinaryStatement", | |
"XMLBase64", | |
"HandlingStatement", | |
"String", | |
}[s] |
sdk/assertion.go
Outdated
) | ||
|
||
func (s Scope) String() string { | ||
return [...]string{"TDO", "PAYL", "EXPLICIT"}[s] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return [...]string{"TDO", "PAYL", "EXPLICIT"}[s] | |
return [...]string{ | |
"TDO", | |
"PAYL", | |
"EXPLICIT", | |
}[s] |
sdk/assertion.go
Outdated
) | ||
|
||
func (a AppliesToState) String() string { | ||
return [...]string{"encrypted", "unencrypted"}[a] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return [...]string{"encrypted", "unencrypted"}[a] | |
return [...]string{ | |
"encrypted", | |
"unencrypted", | |
}[a] |
@@ -51,9 +51,29 @@ type EncryptionInformation struct { | |||
IntegrityInformation `json:"integrityInformation"` | |||
} | |||
|
|||
type Statement struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a spec link you can drop here so I or someone familiar can validate this?
Is this right: http://www.datypic.com/sc/ic/e-tdf_StructuredStatement-1.html
sdk/manifest.go
Outdated
Value string `json:"value"` | ||
Filename string `json:"filename,omitempty"` | ||
MediaType string `json:"mediaType,omitempty"` | ||
Uri string `json:"uri,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the linter errors here for URI and ID needing to be capitalized if appropriate
No description provided.