-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add service scoped database clients #647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrschumacher
commented
Apr 24, 2024
strantalis
reviewed
Apr 24, 2024
jakedoublev
reviewed
Apr 29, 2024
jakedoublev
approved these changes
Apr 29, 2024
strantalis
approved these changes
Apr 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](service/v0.2.0...service/v0.3.0) (2024-04-29) ### Features * **core:** add service scoped database clients ([#647](#647)) ([019a3bf](019a3bf)) ### Bug Fixes * **config:** update docs for enforce dpop config and clean up markdown tables ([#697](#697)) ([983ce71](983ce71)) * **policy:** normalize FQN lookup to lower case ([#668](#668)) ([cd8a875](cd8a875)), closes [#669](#669) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42
added a commit
to tech-guru42/TDF
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](opentdf/platform@service/v0.2.0...service/v0.3.0) (2024-04-29) ### Features * **core:** add service scoped database clients ([#647](opentdf/platform#647)) ([019a3bf](opentdf/platform@019a3bf)) ### Bug Fixes * **config:** update docs for enforce dpop config and clean up markdown tables ([#697](opentdf/platform#697)) ([983ce71](opentdf/platform@983ce71)) * **policy:** normalize FQN lookup to lower case ([#668](opentdf/platform#668)) ([cd8a875](opentdf/platform@cd8a875)), closes [#669](opentdf/platform#669) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127
added a commit
to passion-127/TDF
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](opentdf/platform@service/v0.2.0...service/v0.3.0) (2024-04-29) ### Features * **core:** add service scoped database clients ([#647](opentdf/platform#647)) ([019a3bf](opentdf/platform@019a3bf)) ### Bug Fixes * **config:** update docs for enforce dpop config and clean up markdown tables ([#697](opentdf/platform#697)) ([983ce71](opentdf/platform@983ce71)) * **policy:** normalize FQN lookup to lower case ([#668](opentdf/platform#668)) ([cd8a875](opentdf/platform@cd8a875)), closes [#669](opentdf/platform#669) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a significant change to how we perceive database clients within the platform. The original implementation has a concept of a single database client which services could use. As work was being executed, it became clear that the policy service was one (if not only) service which required a database client.
Recently, we learned that downstream projects that wrap OpenTDF required access to a database client, but this posed a couple concerns:
Supported features
--all
Unsupported features