feat(sdk): Allow setting TDF mime type #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally when I wrote a go implementation I leveraged the Wonder if we should pull that in and also allow an override. |
Co-authored-by: Ryan Schumacher <jschumacher@virtru.com>
|
@strantalis I'd personally vote no on that because that leaves room for unpredictability which I'm not a fan of. I'm just me though, so happy to if the general consensus is in favor. |
ntrevino-virtru
force-pushed
the
feature/ccr-2825/set-tdf-mime-type
branch
2 times, most recently
from
f363a8f
to
289f881
Compare
ntrevino-virtru
force-pushed
the
feature/ccr-2825/set-tdf-mime-type
branch
from
289f881
to
66bc4b6
Compare
dmihalcik-virtru
approved these changes
May 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.3](sdk/v0.2.2...sdk/v0.2.3) (2024-05-21) ### Features * **authz:** Handle jwts as entity chains in decision requests ([#759](#759)) ([65612e0](65612e0)) * **sdk:** Allow setting TDF mime type ([#797](#797)) ([97926a1](97926a1)) ### Bug Fixes * bump internal versions ([#840](#840)) ([8f45f18](8f45f18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.