fix(policy): GetAttributeValuesByFqns and MatchSubjectMappings should not return deactivated policy objects #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
force-pushed
the
fix/deactivated-fqns
branch
from
f76c131
to
8e0d8af
Compare
…ly and warn appropriately
jakedoublev
changed the title
jrschumacher
approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.3](service/v0.4.2...service/v0.4.3) (2024-05-22) ### Features * **authz:** Allow un-scoped GetEntitlements calls ([#833](#833)) ([9146947](9146947)) * **authz:** Handle jwts as entity chains in decision requests ([#759](#759)) ([65612e0](65612e0)) * **ci:** Add e2e roundtrip tests for different attribute combinations ([#790](#790)) ([1b0ec23](1b0ec23)) * **core:** Adds opentdf.hsm build constraint ([#830](#830)) ([e13e52a](e13e52a)) * **core:** audit logging ([#774](#774)) ([ea58b3c](ea58b3c)) ### Bug Fixes * **authz:** Populate fqn field in attribute values returned from GetAttributeValuesByFqns ([#816](#816)) ([0ac8390](0ac8390)) * **authz:** Typo in client secret config ([#835](#835)) ([7cad1f1](7cad1f1)) * bump internal versions ([#840](#840)) ([8f45f18](8f45f18)) * **core:** bump sdk deps to 0.2.3 ([#848](#848)) ([ca8b9f7](ca8b9f7)) * **policy:** fix policy fqn-reindex command schema suffix ([#818](#818)) ([aff9850](aff9850)), closes [#817](#817) * **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should not return deactivated policy objects ([#813](#813)) ([41ca82d](41ca82d)), closes [#494](#494) * **policy:** make resource-mappings update patch instead of put in RESTful gateway ([#824](#824)) ([1878bb5](1878bb5)), closes [#313](#313) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetAttributeValuesByFqnsandMatchSubjectMappingsAPIs on Policy services that support authorization/entitlement now filter out any results with a deactivated namespace, definition, or value of the attribute.Resolves #494