Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes per Stephanie & Tyler conversation #15

Draft
wants to merge 5 commits into
base: json-schema
Choose a base branch
from
Draft

Changes per Stephanie & Tyler conversation #15

wants to merge 5 commits into from

Conversation

stephaniegraham
Copy link

Proposed Changes

Checklist

  • A clear description of the change has been included in this PR.
  • A clear description of whether this change is a Major, Minor, Patch or cosmetic change as per the Versioning Guidelines has been included in this PR.
  • All schema validation tests have been updated appropriately and are passing.
  • MAJOR/MINOR VERSION CHANGES ONLY: This PR should be made in branches prefixed with draft-<change>
  • MAJOR/MINOR VERSION CHANGES ONLY: A link to a reference implementation (PR or set of PRs) of the change has been included in this PR.
  • MAJOR/MINOR VERSION CHANGES ONLY: A writeup has been included discussing the motivation and impact of this change.
  • MAJOR/MINOR VERSION CHANGES ONLY: The minimum wait time has elapsed.
  • DRAFT MERGE ONLY: Draft Semver has been updated in the VERSION file (optional)
  • DRAFT MERGE ONLY: Tagged this branch with new semver version and an annotation describing the change (ex: git tag -s 4.1.0 -m "Spec version 4.1.0 - did a thing")
  • DRAFT MERGE ONLY: Version numbers have been updated as per the Versioning Guidelines.
  • This change otherwise adheres to the project Contribution Guidelines.

biscoe916
biscoe916 reviewed Sep 11, 2023
View reviewed changes
schema/JSON/manifest.schema.json Outdated
"description": "The assertion binding algorithm used to generate the hash.",
"type": "string"
},
"hash": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to signature

biscoe916
biscoe916 reviewed Sep 11, 2023
View reviewed changes
schema/JSON/manifest.schema.json Outdated
}
}
},
"assertionBinding": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to binding

biscoe916
biscoe916 reviewed Sep 11, 2023
View reviewed changes
schema/JSON/manifest.schema.json
@@ -23,6 +23,14 @@
"isEncrypted": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add KeyID

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And SplitID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biscoe916 biscoe916 biscoe916 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephaniegraham @biscoe916