Extension templating #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 13, 2014 11:51
Moved setup functionality into modules and added a basic welcome page as the first extension loaded
Added proper logging and removed unneeded global exception handling
Extension manager created with core functionality to load an installed extension, get a section from a extension, and check the installed extensions.
Moved validation into validate.ClientConfig and moved all file system interaction into QDir's and proper os.path.join's
Moved extension manager into utils because it is logical. Cleaned up code to be more pep8 compliant.
added 28 commits
April 4, 2014 16:34
Added unit-tests, ConfigManager, extension loading functions, and fs_utils that work with zipped files>
Due to config properties setting themselves they were fully recursive. To stop them from turtle-ing all the way down I changed them to set local variables, like they should have in the first place.
Bundled the utility with the extension manager where it belongs.
Removed attempts at translation before application initializes. Added a check for the home directory before attempting to create it so that if it already exists the logger does not fail.
QDir.setPath(\'x\') will change the directory using the current directory as a guide. QDir.cd(\'x\') will change the directory with THAT QDir's current directory as a guide. e.g. when calling code from /home/s2e/ where you create the QDir mydir = QtCore.QDir(\'/tmp/'). mydir.setPath(\'new\') == /home/s2e/new, mydir.cd(\'new\') == /tmp/new.
Core and global extensions will now both live in the application path to get around root permission issues.
seamustuohy
pushed a commit
that referenced
this pull request
Apr 16, 2014
Extension templating work being merged into dev branch on open-tech so other devs can find current working client code with extensions incorporated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development has placed extension templating back to a working state. Pushing back to opentech since it is working enough for front end development.