Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 195 - Fixing broken links in French version of Wireless Challenges #210

Merged
merged 5 commits into from Aug 11, 2014

Conversation

andygunn
Copy link

Fixed images and uploaded missing PDFs. Cleaned up some depreciated style tags from old Drupal site. @natmey @critzo please review!

Andy Gunn added 3 commits July 29, 2014 11:48
…s Challenges module. Corrected some images. Final upload of French version of PDF presentation and problem sets.
@critzo
Copy link

critzo commented Aug 1, 2014

@andygunn Looks good, with the exception of a broken link to the main PDF for the module in the sidebar, presumably because it's being updated? Was this one of the non-Indesign PDFs that was removed? To remove the "Download PDF" button on the right, we just need to drop this line from a page's front matter: pdf: path/to/file.pdf

@andygunn
Copy link
Author

andygunn commented Aug 1, 2014

@critzo I missed that. I think we had a translated version of the PDF, but I will have to hunt for it. If not I will whip one up, upload it and push the change. We have a template for Scribus and LibreOffice now - I just need to decide how fancy I want to be...

@critzo
Copy link

critzo commented Aug 1, 2014

On Fri 01 Aug 2014 10:04:59 AM EDT, Andy Gunn wrote:

@critzo https://github.com/critzo I missed that. I think we had a
translated version of the PDF, but I will have to hunt for it. If not
I will whip one up, upload it and push the change. We have a template
for Scribus and LibreOffice now - I just need to decide how fancy I
want to be...


Reply to this email directly or view it on GitHub
#210 (comment).

@andygunn Look at the PDF on that page on the current site also. I'm
not sure, but it may have been removed in this issue branch. We can use
both, one for each respective translation.

---->
Chris Ritzo
Senior Technologist
Open Technology Institute @ New America Foundation
1899 L St. NW Suite 400 | 202-596-3406
Washington, DC 20036
Public Key: 0x085B309C
8859 E047 852C C3E4 F421 04DD 0285 4037 085B 309C
<----

@andygunn
Copy link
Author

andygunn commented Aug 4, 2014

@critzo @natmey This should be all set now - I added "pretty print" versions of the module for both English and French, and all links should be golden now. Can you take a quick look and merge if all looks good?

andygunn pushed a commit that referenced this pull request Aug 11, 2014
Issue 195 - Fixing broken links in French version of Wireless Challenges
@andygunn andygunn merged commit 1f51dd7 into staging Aug 11, 2014
@andygunn andygunn deleted the issue-195 branch August 22, 2014 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants