Convert new site theme to Bootstrap #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheretic
added a commit
that referenced
this pull request
Nov 16, 2015
Convert new site theme to Bootstrap
|
Thanks @areynold! This is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes preliminary theme conversion begun in #345. Emphasis is on complete conversion of the site to a common template. Further refinement is needed, but those may now be handled as discrete tasks.
The template has been rewritten to use Bootstrap, providing mobile-friendly pages and a deep library of well-documented styles.
I'm using the bootstrap-sass-official Bower module, so bootstrap can be updated using the
bower updatecommand. I am tracking the package components in version control so editors can test their revisions without having to install additional software.We're using SASS to build only the Bootstrap modules we're using, and for Commotion-specific styles. The main stylesheet is defined at
/css/main.scss, and pulls in the necessary SASS modules to be compiled when the site is built.Templates and content are inconsistent across languages. I've pulled in the most recent updates, but many pages were never translated, particularly in the French site. Several template and include files (e.g., the main navigation) need to be rewritten to be language aware. In most cases, the translated include files must be created first. Even on translated pages, links often point back to the main English site.
Blog posts and warning labels are language aware, and may serve as a model for other page components.