Add OpenWRT repositories to local repositories.conf file to match remote one #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheretic
added a commit
that referenced
this pull request
Jun 4, 2015
Add OpenWRT repositories to local repositories.conf file to match remote one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only pulled in the upstream OpenWRT repositories for 'remote' builds, i.e. ones that pulled packages from repos anyway and didn't build any packages. However, in some cases there are bugfixes in core upstream packages that we miss out on (such as, in this case, a bugfix in px5g around generating unique serial numbers).
This adds the upstream package repositories to local builds as well. The disadvantage is that it precludes a completely offline build, however since we generally presuppose that we're building packages for a local build and those pull from online repositories, we maybe don't care so much at the moment.
Addresses #169