new validation functions

[dismantl]

part of https://github.com/opentechinstitute/commotion-lua-helpers/pull/3

[seamustuohy]

Code reviewed by s2e. Ready for functional testing.

[seamustuohy]

App_catagory Validate function failed with the following error when submitting an application:

/usr/lib/lua/luci/dispatcher.lua:448: Failed to execute call dispatcher target for entry '/admin/commotion/apps/add_submit'.
The called action terminated with an exception:
/usr/lib/lua/luci/commotion/validate.lua:114: attempt to index global 'luci' (a nil value)
stack traceback:
    [C]: in function 'assert'
    /usr/lib/lua/luci/dispatcher.lua:448: in function 'dispatch'
    /usr/lib/lua/luci/dispatcher.lua:195: in function </usr/lib/lua/luci/dispatcher.lua:194>

To fix this I changed line 114 of /usr/lib/lua/luci/commotion/validate.lua to reference the existing uci cursor instead of attempting to use the globaly scoped luci.model.uci function which does not exist in a modules not using package.seeall:

- local _uci = luci.model.uci.cursor()
+ local _uci = uci.cursor()

---

After this change I encountered the following error upon resubmitting the same application.

/usr/lib/lua/luci/dispatcher.lua:448: Failed to execute call dispatcher target for entry '/admin/commotion/apps/add_submit'.
The called action terminated with an exception:
/usr/lib/lua/luci/commotion/validate.lua:116: attempt to call global 'type' (a nil value)
stack traceback:
    [C]: in function 'assert'
    /usr/lib/lua/luci/dispatcher.lua:448: in function 'dispatch'
    /usr/lib/lua/luci/dispatcher.lua:195: in function </usr/lib/lua/luci/dispatcher.lua:194>

Adding the following line before the "local validate = {}" call addressed this error. Again, it was a stock function not carried forward into the local sandbox of the module.

local type = type                                                                   

[seamustuohy]

FIRST BUG : /usr/lib/lua/luci/commotion/validate.lua:114: attempt to index global 'luci' (a nil value) = FIXED!

SECOND BUG: /usr/lib/lua/luci/commotion/validate.lua:116: attempt to call global 'type' (a nil value) = FIXED!