Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject ssh changes with invalid root password #170

Merged
merged 3 commits into from Feb 24, 2014
Merged

Conversation

areynold
Copy link
Collaborator

Closes #155

To test:

  1. Open Administration > Advanced > System > Administration in a web browser
  2. SSH into the node and run uci show dropbear
  3. Using an incorrect/blank root password, change a number of settings on the page, including ssh keys.
  4. Click Save, then run uci show dropbear from the command line. The settings should not have changed. If you added an ssh key, it should not have been added to /etc/dropbear/authorized_keys.
  5. Repeat using an incorrect root password and Save & Apply instead of Save. Your settings should not appear in /etc/config/dropbear.
  6. Enter the correct root password and repeat. Your new settings should have been saved.

@areynold areynold added this to the 1.1 milestone Feb 24, 2014
@jheretic jheretic self-assigned this Feb 24, 2014
jheretic added a commit that referenced this pull request Feb 24, 2014
Reject ssh changes with invalid root password, tested successfully by @jheretic.
@jheretic jheretic merged commit e4fd669 into master Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main system page allows changing form values (eg. adding ssh keys) without password
2 participants