Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Check for disabled dashboard is ignored #238

Closed
oti-tech opened this issue Jun 18, 2014 · 2 comments
Closed

[CLOSED] Check for disabled dashboard is ignored #238

oti-tech opened this issue Jun 18, 2014 · 2 comments

Comments

@oti-tech
Copy link

Issue by areynold
Saturday Dec 21, 2013 at 15:39 GMT
Originally opened as https://github.com/opentechinstitute/commotion-dashboard-helper/issues/13


Using default configuration, dashboard cron job should end early due to "do return end" on line 6 of commotion-bigboard-send.

Instead we're hitting the sanity check on line 45.

Can be fixed by moving the rest of the script into a function and calling it from an else statement on line 7-9.

@oti-tech
Copy link
Author

Comment by jheretic
Wednesday Jan 08, 2014 at 16:08 GMT


@areynold, what's the status of this issue?

@oti-tech
Copy link
Author

Comment by areynold
Wednesday Jan 08, 2014 at 16:10 GMT


Sorry. Thought I closed that. It was fixed in 6c9f24a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants