Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] added checks for ipv4 addresses table and address value before calling t... #266

Closed
oti-tech opened this issue Jun 18, 2014 · 1 comment

Comments

@oti-tech
Copy link

Issue by elationfoundation
Tuesday Jan 21, 2014 at 15:31 GMT
Originally opened as https://github.com/opentechinstitute/luci-theme-commotion/pull/17


...hem.
Fix for issues 141 on luci-commotion.

#141

To test:

  1. Take an R1 node and restart networking and configuring all sorts of things until luci-commotion issue 95 appears. dnsmasq networking error breaks interfaces commotion-router#95 This will break all the interfaces.
  2. scp over this modified header to replace the existing header file
  3. remove the luci-cach's on the node.
  4. refresh page

If the page loads then this fix works.


elationfoundation included the following code: https://github.com/opentechinstitute/luci-theme-commotion/pull/17/commits

@oti-tech
Copy link
Author

Comment by dismantl
Wednesday Feb 19, 2014 at 14:25 GMT


this pull request broke the theme by adding an extra 'end' tag, see: https://github.com/opentechinstitute/luci-theme-commotion/pull/20.

Don't forget to have others test and merge your pull requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants