Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editing and grouping to items on confirmation page. #86

Open
seamustuohy opened this issue Nov 19, 2013 · 6 comments
Open

Add editing and grouping to items on confirmation page. #86

seamustuohy opened this issue Nov 19, 2013 · 6 comments

Comments

@seamustuohy
Copy link
Collaborator

Title:Confirm Configuration
Help text: Review the settings you have chosen below. To finish the Setup Wizard click “Apply” at the bottom of this page. The device will restart when you click apply. You will lose access while it restarts.
This page will have a list of all configurations saved, but not yet applied, during the current session.
Each configuration will be directly manipulatable on this page.
Each configuration item will have a revert button next to it that will reload the page with that value removed (reverted to previous value and therefore no-longer changed)
Upon completing this page all settings will be applied taking you to the applying changes page.

@seamustuohy
Copy link
Collaborator Author

@critzo @georgiamoon

This page requires two buttons. One button to revert all changes and one button to apply all changes. What should those buttons be titled?

revert button:
apply button:
There will also be a loading page that will appear for a short amount of time when a user clicks revert or apply before taking the user to the first QS page (if revert) or the admin login (if apply). If you have thoughts on that language you can post it here and I will add it.

@georgiamoon
Copy link
Member

I think the version you showed us earlier that has "Revert" and "Save and Apply" is good.

On the Loading page, I would include a statement that says:

Save & Apply Condition:
"Applying changes...
Please be patient, this may take a few moments. Once the settings are complete you will be returned to the Administrative login."

Revert Condition:
"Reverting changes...
Please be patient, this may take a few moments. Once the settings are reset you will be returned to the beginning of the Setup Wizard."

@critzo
Copy link

critzo commented Dec 15, 2013

@georgiamoon @elationfoundation We talked more about these buttons on Friday. There are more than two. Documenting that conversation here so it's not lost.
"Start Over" (replaces "Revert") --> restarts Setup Wizard, wiping out settings made previously
"Make Changes" --> returns to beginning of Setup Wizard, keeping previously made settings
"Save & Apply" --> saves & applies all settings

@jheretic
Copy link
Member

Is this issue still relevant with regards to v1.1rc1?

@georgiamoon
Copy link
Member

I feel that the grouping is complete, although we could extend it to say that the configuration changes should be grouped by the menu categories if that's possible.

There is no "Start over" button as is mentioned in the discussion here, so if that is still desired, then yes, this is still relevant.

screen shot 2014-04-16 at 2 53 53 pm

@seamustuohy
Copy link
Collaborator Author

It is still relevant. This issue was to abstract the config file organization into a set of sections based upon the wireless interface and its rules.

@jheretic jheretic modified the milestone: 1.2 Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants