keyring_open_with_pins() is gone (plus Makefile spiff-up) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Serval include directory and lib directory in separate places. Only set them in the Makefile if they are not set on the command line.
Replace it with a call to keyring_open_instance() which does almost exactly the same thing!
jheretic
added a commit
that referenced
this pull request
Aug 27, 2013
keyring_open_with_pins() is gone (plus Makefile spiff-up) - Still needs additional testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the mdp plugin in line with serval-dna where keyring_open_with_pins() is no longer around.
Also, this allows a user to place their Serval source and compiled libservald.so in separate directories!