Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] CSS #425

Merged
merged 6 commits into from
Oct 13, 2022
Merged

[Refactor] CSS #425

merged 6 commits into from
Oct 13, 2022

Conversation

Aloento
Copy link
Member

@Aloento Aloento commented Sep 15, 2022

Move all API methods and related structures to a separate file.
Inline all Extracts and use the extract package instead.
Remove all Builders

@Aloento Aloento marked this pull request as ready for review September 15, 2022 09:11
@Aloento Aloento self-assigned this Sep 15, 2022
@Aloento Aloento added the enhancement New feature or request label Sep 15, 2022
@Aloento Aloento removed the request for review from outcatcher October 6, 2022 06:47
@Aloento Aloento added the post Execute check-post jobs label Oct 13, 2022
golangsdk "github.com/opentelekomcloud/gophertelekomcloud"
)

func WaitForClusterOperationSucces(client *golangsdk.ServiceClient, id string, timeout int) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little typo success with ss

@Aloento Aloento added gate Merge PR and removed post Execute check-post jobs labels Oct 13, 2022
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Oct 13, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/eb9109ca73ae4a13b50cb23810291f41

✔️ otc-golangci-lint SUCCESS in 2m 17s
✔️ golang-make-vet SUCCESS in 1m 50s
✔️ golang-make-test SUCCESS in 2m 20s
✔️ golang-make-functional SUCCESS in 6m 16s

@otc-zuul otc-zuul bot merged commit 1a9bd86 into devel Oct 13, 2022
@otc-zuul otc-zuul bot deleted the css branch October 13, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants