Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LTS] API Update #469

Merged
merged 21 commits into from
Jan 10, 2023
Merged

[LTS] API Update #469

merged 21 commits into from
Jan 10, 2023

Conversation

Aloento
Copy link
Member

@Aloento Aloento commented Nov 16, 2022

fix #428

@Aloento Aloento added the enhancement New feature or request label Nov 16, 2022
@Aloento Aloento self-assigned this Nov 16, 2022
@Aloento Aloento changed the title [LTS] Refactor & API Updated [LTS] Refactor & API Update Nov 16, 2022
@Aloento Aloento marked this pull request as ready for review November 16, 2022 13:54
@Aloento Aloento changed the title [LTS] Refactor & API Update [LTS] Refactor Nov 16, 2022
artem-lifshits
artem-lifshits previously approved these changes Jan 9, 2023
View reviewed changes
@Aloento Aloento added the gate Merge PR label Jan 9, 2023
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Jan 9, 2023

Build failed.
https://zuul.otc-service.com/t/eco/buildset/5e8c034d9117412d8be8c84388cc5378

✔️ otc-golangci-lint SUCCESS in 2m 15s
✔️ golang-make-vet SUCCESS in 1m 58s
✔️ golang-make-test SUCCESS in 2m 18s
❌ golang-make-functional FAILURE in 6m 15s

@Aloento Aloento removed the gate Merge PR label Jan 9, 2023
@artem-lifshits artem-lifshits added the gate Merge PR label Jan 9, 2023
@Aloento Aloento changed the title [LTS] Refactor [LTS] API Update Jan 9, 2023
@Aloento Aloento removed the gate Merge PR label Jan 9, 2023
@Aloento Aloento marked this pull request as draft January 9, 2023 14:44
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Jan 9, 2023

This change is unable to merge due to a missing merge requirement.

@artem-lifshits artem-lifshits self-requested a review January 9, 2023 15:55
artem-lifshits
artem-lifshits previously approved these changes Jan 9, 2023
View reviewed changes
@artem-lifshits artem-lifshits added the gate Merge PR label Jan 9, 2023
@artem-lifshits artem-lifshits removed the gate Merge PR label Jan 9, 2023
artem-lifshits
artem-lifshits requested changes Jan 9, 2023
View reviewed changes
openstack/lts/v2/transfers/DeleteTransfer.go Outdated Show resolved Hide resolved
openstack/lts/v2/transfers/UpdateTransfer.go Outdated Show resolved Hide resolved
artem-lifshits
artem-lifshits requested changes Jan 9, 2023
View reviewed changes
openstack/common/pointerto/pointers.go Outdated Show resolved Hide resolved
openstack/lts/v2/streams/ListLogs.go Outdated Show resolved Hide resolved
acceptance/openstack/lts/v2/lts_test.go Show resolved Hide resolved
@artem-lifshits artem-lifshits added the gate Merge PR label Jan 10, 2023
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Jan 10, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/4b95da6296874059b6925837fdbafe9d

✔️ otc-golangci-lint SUCCESS in 2m 17s
✔️ golang-make-vet SUCCESS in 1m 56s
✔️ golang-make-test SUCCESS in 2m 16s
✔️ golang-make-functional SUCCESS in 6m 18s

@otc-zuul otc-zuul bot merged commit 54b5597 into devel Jan 10, 2023
@otc-zuul otc-zuul bot deleted the lts branch January 10, 2023 09:47
artem-lifshits pushed a commit that referenced this pull request Jun 30, 2023
@Aloento
[LTS] API Update (#469)
4346970 
[LTS] API Update

fix #428

Reviewed-by: Artem Lifshits
Reviewed-by: Anton Sidelnikov
Reviewed-by: Aloento
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

Assignees

@Aloento Aloento

Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LTS] API Updated
3 participants
@Aloento @anton-sidelnikov @artem-lifshits