Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRS] Refactor #471

Merged
merged 23 commits into from
Feb 1, 2023
Merged

[MRS] Refactor #471

merged 23 commits into from
Feb 1, 2023

Conversation

Aloento
Copy link
Member

@Aloento Aloento commented Nov 17, 2022 •
edited
Loading

No description provided.

@Aloento Aloento added the enhancement New feature or request label Nov 17, 2022
@Aloento Aloento self-assigned this Nov 17, 2022
@Aloento Aloento changed the title [MRS] API Update [MRS] Refactor Nov 21, 2022
@Aloento Aloento marked this pull request as ready for review November 21, 2022 09:27
@anton-sidelnikov
Copy link
Member

You refactored too many files not related to MRS, please exclude it from PR

@Aloento Aloento added the post Execute check-post jobs label Feb 1, 2023
@Aloento Aloento removed the post Execute check-post jobs label Feb 1, 2023
@Aloento Aloento added the post Execute check-post jobs label Feb 1, 2023
@Aloento Aloento removed the post Execute check-post jobs label Feb 1, 2023
@Aloento Aloento added the gate Merge PR label Feb 1, 2023
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Feb 1, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/4a89e109285f46ac843c053f29ea0adb

✔️ otc-golangci-lint SUCCESS in 2m 12s
✔️ golang-make-vet SUCCESS in 1m 48s
✔️ golang-make-test SUCCESS in 2m 26s
✔️ golang-make-functional SUCCESS in 6m 16s

@otc-zuul otc-zuul bot merged commit 2c0e640 into devel Feb 1, 2023
@otc-zuul otc-zuul bot deleted the mrs branch February 1, 2023 18:47
bakhterets
bakhterets reviewed Feb 2, 2023
View reviewed changes
Copy link

@bakhterets bakhterets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewed

artem-lifshits pushed a commit that referenced this pull request Jun 30, 2023
@Aloento
[MRS] Refactor (#471)
8ff17b1 
[MRS] Refactor

Reviewed-by: Anton Sidelnikov
Reviewed-by: Vladimir Vshivkov
Reviewed-by: Aloento
Reviewed-by: Artem Lifshits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakhterets bakhterets bakhterets left review comments

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@Aloento Aloento

Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Aloento @anton-sidelnikov @vladimirvshivkov @bakhterets @artem-lifshits