Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FWAAS]: remove omitempty from souce/destination ports #543

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[FWAAS]: remove omitempty from souce/destination ports #543

merged 1 commit into from
Jul 4, 2023

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Jul 4, 2023 •
edited
Loading

What this PR does / why we need it

Remove omitempty so source and destination ports could assign nil value.
Test added.

@artem-lifshits artem-lifshits self-assigned this Jul 4, 2023
@artem-lifshits artem-lifshits added the gate Merge PR label Jul 4, 2023
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Jul 4, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/70ab459d73c04c44b64cd8f55de5ae04

✔️ otc-golangci-lint SUCCESS in 2m 14s
✔️ golang-make-vet SUCCESS in 2m 01s
✔️ golang-make-test SUCCESS in 2m 23s
✔️ golang-make-functional SUCCESS in 7m 32s

@otc-zuul otc-zuul bot merged commit 65a7d0a into devel Jul 4, 2023
2 checks passed
@otc-zuul otc-zuul bot deleted the fw_rule_fix branch July 4, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polina-Gubina Polina-Gubina Polina-Gubina approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@Aloento Aloento Awaiting requested review from Aloento

Assignees

@artem-lifshits artem-lifshits

Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artem-lifshits @Polina-Gubina @anton-sidelnikov