[WAF] dedicated rules attributes update #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-lifshits
previously approved these changes
Sep 19, 2023
Polina-Gubina
previously approved these changes
Sep 19, 2023
|
Build failed. ✔️ otc-golangci-lint SUCCESS in 2m 51s |
|
Build failed. ✔️ otc-golangci-lint SUCCESS in 2m 19s |
anton-sidelnikov
dismissed stale reviews from Polina-Gubina and artem-lifshits
via
fad6217
Polina-Gubina
previously approved these changes
Sep 19, 2023
artem-lifshits
previously approved these changes
Sep 19, 2023
Aloento
previously approved these changes
Sep 19, 2023
Polina-Gubina
previously approved these changes
Sep 19, 2023
anton-sidelnikov
dismissed stale reviews from Polina-Gubina, Aloento, and artem-lifshits
via
c208714
anton-sidelnikov
requested review from
Aloento,
Polina-Gubina and
artem-lifshits
artem-lifshits
approved these changes
Sep 19, 2023
anton-sidelnikov
added
post
Aloento
approved these changes
Sep 19, 2023
artem-lifshits
approved these changes
Sep 19, 2023
|
Build succeeded. ✔️ otc-golangci-lint SUCCESS in 2m 19s |
artem-lifshits
pushed a commit
that referenced
this pull request
Jan 11, 2024
[WAF] dedicated rules attributes update
For some rules necessary to set omitempty
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
=== RUN TestWafPremiumBlacklistRuleWorkflow
rule_test.go:30: Attempting to create WAF Premium policy: waf-policy-r7t
rule_test.go:49: Attempting to create WAF Premium host
rule_test.go:66: Attempting to Create WAF Premium blacklist rule
rule_test.go:80: Attempting to List WAF Premium blacklist rule
rule_test.go:87: Attempting to Update WAF Premium blacklist rule: 6915c3435a40473399890e99314b5a94
rule_test.go:96: Attempting to Get WAF Premium blacklist rule: 6915c3435a40473399890e99314b5a94
rule_test.go:75: Attempting to delete WAF Premium blacklist rule: 6915c3435a40473399890e99314b5a94
rule_test.go:77: Deleted WAF Premium blacklist rule: 6915c3435a40473399890e99314b5a94
rule_test.go:54: Attempting to delete WAF Premium host: e785662a2ec64eabbd3a3f41b2a30d9f
rule_test.go:56: Deleted WAF Premium host: e785662a2ec64eabbd3a3f41b2a30d9f
--- PASS: TestWafPremiumBlacklistRuleWorkflow (5.46s)
=== RUN TestWafPremiumCcRuleWorkflow
rule_test.go:140: Attempting to Create WAF Premium cc rule
rule_test.go:152: Attempting to List WAF Premium cc rule
rule_test.go:159: Attempting to Update WAF Premium cc rule: f10c4c7caaaf4dcfb5f0b1bd5be9eea2
rule_test.go:173: Attempting to Get WAF Premium cc rule: f10c4c7caaaf4dcfb5f0b1bd5be9eea2
rule_test.go:147: Attempting to delete WAF Premium cc rule: f10c4c7caaaf4dcfb5f0b1bd5be9eea2
rule_test.go:149: Deleted WAF Premium cc rule: f10c4c7caaaf4dcfb5f0b1bd5be9eea2
rule_test.go:124: Attempting to delete WAF Premium policy: 775d51adc775497f8c8b9545d0cbbd90
rule_test.go:126: Deleted WAF Premium policy: 775d51adc775497f8c8b9545d0cbbd90
--- PASS: TestWafPremiumCcRuleWorkflow (3.83s)
=== RUN TestWafPremiumCustomRuleWorkflow
rule_test.go:217: Attempting to Create WAF Premium custom rule
rule_test.go:229: Attempting to List WAF Premium custom rule
rule_test.go:236: Attempting to Update WAF Premium custom rule: 33e1a2b95af541c7ad4bbea8802dd9ab
rule_test.go:252: Attempting to Get WAF Premium custom rule: 33e1a2b95af541c7ad4bbea8802dd9ab
rule_test.go:224: Attempting to delete WAF Premium custom rule: 33e1a2b95af541c7ad4bbea8802dd9ab
rule_test.go:226: Deleted WAF Premium custom rule: 33e1a2b95af541c7ad4bbea8802dd9ab
rule_test.go:199: Attempting to delete WAF Premium policy: 428cdfd710f44f9d970fb784c767efae
rule_test.go:201: Deleted WAF Premium policy: 428cdfd710f44f9d970fb784c767efae
--- PASS: TestWafPremiumCustomRuleWorkflow (4.24s)
=== RUN TestWafPremiumAntiCrawlerRuleWorkflow
rule_test.go:290: Attempting to Create WAF Premium anti crawler rule
rule_test.go:301: Attempting to List WAF Premium anti crawler rule
rule_test.go:308: Attempting to Update WAF Premium anti crawler rule: 02542321959c4e6c9b6fd8c251be7d0a
rule_test.go:316: Attempting to Get WAF Premium anti crawler rule: 02542321959c4e6c9b6fd8c251be7d0a
rule_test.go:296: Attempting to delete WAF Premium anti crawler rule: 02542321959c4e6c9b6fd8c251be7d0a
rule_test.go:298: Deleted WAF Premium anti crawler rule: 02542321959c4e6c9b6fd8c251be7d0a
rule_test.go:278: Attempting to delete WAF Premium policy: 5483deee8381434683deb890ab2db955
rule_test.go:280: Deleted WAF Premium policy: 5483deee8381434683deb890ab2db955
--- PASS: TestWafPremiumAntiCrawlerRuleWorkflow (4.86s)
=== RUN TestWafPremiumDataMaskingRuleWorkflow
rule_test.go:354: Attempting to Create WAF Premium privacy rule
rule_test.go:366: Attempting to List WAF Premium privacy rule
rule_test.go:373: Attempting to Update WAF Premium privacy rule: ae70cf7c4e9d43cd838899d06ff3f806
rule_test.go:382: Attempting to Get WAF Premium privacy rule: 02d1fc49992e4814afe6e1b003701585
rule_test.go:361: Attempting to delete WAF Premium privacy rule: 02d1fc49992e4814afe6e1b003701585
rule_test.go:363: Deleted WAF Premium privacy rule: 02d1fc49992e4814afe6e1b003701585
rule_test.go:343: Attempting to delete WAF Premium policy: ae70cf7c4e9d43cd838899d06ff3f806
rule_test.go:345: Deleted WAF Premium policy: ae70cf7c4e9d43cd838899d06ff3f806
--- PASS: TestWafPremiumDataMaskingRuleWorkflow (4.68s)
=== RUN TestWafPremiumKnownAttackRuleWorkflow
rule_test.go:419: Attempting to Create WAF Premium known attack source rule
rule_test.go:432: Attempting to List WAF Premium known attack source rule
rule_test.go:439: Attempting to Update WAF Premium known attack source rule: df04dfce1585456db1223e1271336095
rule_test.go:446: Attempting to Get WAF Premium known attack source rule: ff8f6732629444e6b6d531e7e39b8a17
rule_test.go:427: Attempting to delete WAF Premium known attack source rule: ff8f6732629444e6b6d531e7e39b8a17
rule_test.go:429: Deleted WAF Premium known attack source rule: ff8f6732629444e6b6d531e7e39b8a17
rule_test.go:409: Attempting to delete WAF Premium policy: df04dfce1585456db1223e1271336095
rule_test.go:411: Deleted WAF Premium policy: df04dfce1585456db1223e1271336095
--- PASS: TestWafPremiumKnownAttackRuleWorkflow (4.90s)
=== RUN TestWafPremiumWebTamperRuleWorkflow
rule_test.go:481: Attempting to Create WAF Premium anti tamper rule
rule_test.go:494: Attempting to List WAF Premium anti tamper rule
rule_test.go:501: Attempting to Update WAF Premium anti tamper rule: e3a960c36d974ddcb0a9c00c4c20efe1
rule_test.go:505: Attempting to Get WAF Premium anti tamper rule: ab08df730900487aa692409744c5d884
rule_test.go:489: Attempting to delete WAF Premium anti tamper rule: ab08df730900487aa692409744c5d884
rule_test.go:491: Deleted WAF Premium anti tamper rule: ab08df730900487aa692409744c5d884
rule_test.go:472: Attempting to delete WAF Premium policy: e3a960c36d974ddcb0a9c00c4c20efe1
rule_test.go:474: Deleted WAF Premium policy: e3a960c36d974ddcb0a9c00c4c20efe1
--- PASS: TestWafPremiumWebTamperRuleWorkflow (4.58s)
=== RUN TestWafPremiumInformationLeakageProtectionRuleWorkflow
rule_test.go:541: Attempting to Create WAF Premium information leakage protection rule
rule_test.go:555: Attempting to List WAF Premium information leakage protection rule
rule_test.go:562: Attempting to Update WAF Premium information leakage protection rule: 9c2b7bd0b46e4679aead01afdaa94170
rule_test.go:571: Attempting to Get WAF Premium information leakage protection rule: e980689b6e494e958835d006feb2a457
rule_test.go:550: Attempting to delete WAF Premium information leakage protection rule: e980689b6e494e958835d006feb2a457
rule_test.go:552: Deleted WAF Premium information leakage protection rule: e980689b6e494e958835d006feb2a457
rule_test.go:531: Attempting to delete WAF Premium policy: 9c2b7bd0b46e4679aead01afdaa94170
rule_test.go:533: Deleted WAF Premium policy: 9c2b7bd0b46e4679aead01afdaa94170
--- PASS: TestWafPremiumInformationLeakageProtectionRuleWorkflow (4.63s)
=== RUN TestWafPremiumAlarmMaskingRuleWorkflow
rule_test.go:613: Attempting to Create WAF Premium alarm masking rule
rule_test.go:624: Attempting to List WAF Premium alarm masking rule
rule_test.go:631: Attempting to Update WAF Premium alarm masking rule: 9a250e51c3f74925b481200750533fd2
rule_test.go:645: Attempting to Get WAF Premium alarm masking rule: dd95f2fa78ce4c10b5d91a4160e25961
rule_test.go:619: Attempting to delete WAF Premium alarm masking rule: dd95f2fa78ce4c10b5d91a4160e25961
rule_test.go:621: Deleted WAF Premium information leakage protection rule: dd95f2fa78ce4c10b5d91a4160e25961
rule_test.go:598: Attempting to delete WAF Premium policy: 9a250e51c3f74925b481200750533fd2
rule_test.go:600: Deleted WAF Premium policy: 9a250e51c3f74925b481200750533fd2
--- PASS: TestWafPremiumAlarmMaskingRuleWorkflow (4.62s)
=== RUN TestWafPremiumGeoIpRuleWorkflow
rule_test.go:680: Attempting to Create WAF Premium geo ip rule
rule_test.go:694: Attempting to List WAF Premium geo ip rule
rule_test.go:701: Attempting to Update WAF Premium geo ip rule: b19955020e714da5b6a77dfd3d1bf069
rule_test.go:710: Attempting to Get WAF Premium geo ip rule: 638de30b821a49498f7214ad5ca93c6d
rule_test.go:689: Attempting to delete WAF Premium geo ip rule: 638de30b821a49498f7214ad5ca93c6d
rule_test.go:691: Deleted WAF Premium geo ip rule: 638de30b821a49498f7214ad5ca93c6d
rule_test.go:670: Attempting to delete WAF Premium policy: b19955020e714da5b6a77dfd3d1bf069
rule_test.go:672: Deleted WAF Premium policy: b19955020e714da5b6a77dfd3d1bf069
--- PASS: TestWafPremiumGeoIpRuleWorkflow (4.30s)
=== RUN TestWafPremiumRefTableWorkflow
rule_test.go:720: Deletion not working
--- SKIP: TestWafPremiumRefTableWorkflow (0.00s)
Test ignored.
PASS
Process finished with the exit code 0
Reviewed-by: Artem Lifshits
Reviewed-by: Polina Gubina
Reviewed-by: Aloento
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some rules necessary to set omitempty
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer