[EIP] alias support for eip #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-sidelnikov
requested review from
Aloento,
vladimirvshivkov and
Polina-Gubina
vladimirvshivkov
approved these changes
Oct 6, 2023
Aloento
approved these changes
Oct 6, 2023
| @@ -30,6 +30,7 @@ type PublicIp struct { | |||
| BandwidthSize int `json:"bandwidth_size"` | |||
| BandwidthShareType string `json:"bandwidth_share_type"` | |||
| IpVersion int `json:"ip_version"` | |||
| Name string `json:"alias"` | |||
There was a problem hiding this comment.
Maybe change it to alias? Now we have 2 name attributes in BandwidthOpts and PublicIpOpts which are difficult to distinguish.
There was a problem hiding this comment.
it called name in UI, on tf side it will be IpName, also this opts not intersects
artem-lifshits
approved these changes
Oct 6, 2023
|
Build succeeded. ✔️ otc-golangci-lint SUCCESS in 2m 15s |
artem-lifshits
pushed a commit
that referenced
this pull request
Jan 11, 2024
[EIP] alias support for eip What this PR does / why we need it Which issue this PR fixes Special notes for your reviewer Reviewed-by: Vladimir Vshivkov Reviewed-by: Aloento Reviewed-by: Artem Lifshits Reviewed-by: Anton Sidelnikov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer