[SMN] additional headers on service client level for smn tags #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-sidelnikov
requested review from
Aloento,
vladimirvshivkov and
Polina-Gubina
artem-lifshits
approved these changes
Oct 11, 2023
vladimirvshivkov
approved these changes
Oct 11, 2023
Aloento
approved these changes
Oct 11, 2023
|
Build succeeded. ✔️ otc-golangci-lint SUCCESS in 2m 29s |
artem-lifshits
pushed a commit
that referenced
this pull request
Jan 11, 2024
[SMN] additional headers on service client level for smn tags
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
Tests
=== RUN TestTopicAttributeWorkflow
helpers.go:15: Attempting to create SMN topic
helpers.go:22: Created SMN topic: urn:smn:eu-de:5045c215010c440d91b2f7dce1f3753b:topic-hI6
helpers.go:40: Attempting to create SMN topic tags: [{muh lala} {kuh lala}]
helpers.go:48: SMN topic tags: [{muh lala} {kuh lala}]
helpers.go:57: Attempting to delete SMN topic tag
helpers.go:65: Attempting to delete SMN topic: urn:smn:eu-de:5045c215010c440d91b2f7dce1f3753b:topic-hI6
helpers.go:68: Deleted SMN topic: urn:smn:eu-de:5045c215010c440d91b2f7dce1f3753b:topic-hI6
--- PASS: TestTopicAttributeWorkflow (2.92s)
PASS
Process finished with the exit code 0
=== RUN TestVPCListing
--- PASS: TestVPCListing (3.47s)
=== RUN TestVPCListing/ID
=== PAUSE TestVPCListing/ID
=== CONT TestVPCListing/ID
--- PASS: TestVPCListing/ID (0.69s)
=== RUN TestVPCListing/Name
=== PAUSE TestVPCListing/Name
=== CONT TestVPCListing/Name
--- PASS: TestVPCListing/Name (0.65s)
=== RUN TestVPCLifecycle
--- PASS: TestVPCLifecycle (5.25s)
PASS
Process finished with the exit code 0
Reviewed-by: Artem Lifshits
Reviewed-by: Vladimir Vshivkov
Reviewed-by: Aloento
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
Tests
=== RUN TestTopicAttributeWorkflow
helpers.go:15: Attempting to create SMN topic
helpers.go:22: Created SMN topic: urn:smn:eu-de:5045c215010c440d91b2f7dce1f3753b:topic-hI6
helpers.go:40: Attempting to create SMN topic tags: [{muh lala} {kuh lala}]
helpers.go:48: SMN topic tags: [{muh lala} {kuh lala}]
helpers.go:57: Attempting to delete SMN topic tag
helpers.go:65: Attempting to delete SMN topic: urn:smn:eu-de:5045c215010c440d91b2f7dce1f3753b:topic-hI6
helpers.go:68: Deleted SMN topic: urn:smn:eu-de:5045c215010c440d91b2f7dce1f3753b:topic-hI6
--- PASS: TestTopicAttributeWorkflow (2.92s)
PASS
Process finished with the exit code 0
=== RUN TestVPCListing
--- PASS: TestVPCListing (3.47s)
=== RUN TestVPCListing/ID
=== PAUSE TestVPCListing/ID
=== CONT TestVPCListing/ID
--- PASS: TestVPCListing/ID (0.69s)
=== RUN TestVPCListing/Name
=== PAUSE TestVPCListing/Name
=== CONT TestVPCListing/Name
--- PASS: TestVPCListing/Name (0.65s)
=== RUN TestVPCLifecycle
--- PASS: TestVPCLifecycle (5.25s)
PASS
Process finished with the exit code 0