[VPC] route table and page refactoring with deprecations #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-lifshits
previously approved these changes
Oct 24, 2023
anton-sidelnikov
requested review from
Aloento,
vladimirvshivkov,
Polina-Gubina and
artem-lifshits
anton-sidelnikov
changed the title
artem-lifshits
approved these changes
Oct 24, 2023
vladimirvshivkov
approved these changes
Oct 24, 2023
Aloento
approved these changes
Oct 25, 2023
|
Build succeeded. ✔️ otc-golangci-lint SUCCESS in 2m 22s |
Closed
artem-lifshits
pushed a commit
that referenced
this pull request
Jan 11, 2024
[VPC] route table and page refactoring with deprecations What this PR does / why we need it Which issue this PR fixes Special notes for your reviewer === RUN TestRouteTablesList --- PASS: TestRouteTablesList (0.81s) === RUN TestRouteTablesLifecycle routetables_test.go:46: Attempting to create first vpc: acc-vpc-1-bkM routetables_test.go:50: Created first vpc: d03c12ac-a566-4aac-8fa3-b9d079abc4fb routetables_test.go:59: Attempting to create first subnet: acc-subnet-1-1-iTX routetables_test.go:71: Attempting to create second subnet: acc-subnet-2-1-oXi routetables_test.go:88: Attempting to create second vpc: acc-vpc-2-d6i routetables_test.go:92: Created second vpc: f9fc1d04-1a9f-430a-8f54-c54e77341bea routetables_test.go:101: Attempting to create subnet for second vpc: acc-subnet-1-2-rC8 routetables_test.go:110: Attempting to create peering connection between first and second vpc routetables_test.go:131: Attempting to create route table routetables_test.go:145: Attempting to get route table: 20609fa7-61d9-4903-8c43-205fff83e5c8 routetables_test.go:150: Attempting to associate subnets to vpc route table: 20609fa7-61d9-4903-8c43-205fff83e5c8 2023/10/24 17:41:51 Attempting to update VPC route table with peering route: "20609fa7-61d9-4903-8c43-205fff83e5c8" routetables_test.go:210: Attempting to create cloud server: acc-ecs-2kG common.go:184: Attempting to create ECSv1 common.go:197: Created ECSv1 instance: d079022f-7e66-418b-ad4a-e6827c4c1896 2023/10/24 17:43:04 Attempting to update VPC route table with ecs route: "20609fa7-61d9-4903-8c43-205fff83e5c8" routetables_test.go:239: Attempting to disassociate subnets to vpc route table: 20609fa7-61d9-4903-8c43-205fff83e5c8 common.go:203: Attempting to delete ECSv1: d079022f-7e66-418b-ad4a-e6827c4c1896 common.go:220: ECSv1 instance deleted: d079022f-7e66-418b-ad4a-e6827c4c1896 routetables_test.go:124: Attempting to delete vpc peering connection: e645e5e4-522d-4606-b586-e71846e1fc58 helpers.go:156: Attempting to delete subnet: 91cbb672-1622-4b1f-86cf-b987e6dc2c25 helpers.go:161: Waiting for subnet 91cbb672-1622-4b1f-86cf-b987e6dc2c25 to be deleted helpers.go:165: Deleted subnet: 91cbb672-1622-4b1f-86cf-b987e6dc2c25 helpers.go:218: Attempting to delete vpc: f9fc1d04-1a9f-430a-8f54-c54e77341bea helpers.go:223: Deleted vpc: f9fc1d04-1a9f-430a-8f54-c54e77341bea helpers.go:156: Attempting to delete subnet: 7d288385-a35d-4bff-b305-0f7cc9615a57 helpers.go:161: Waiting for subnet 7d288385-a35d-4bff-b305-0f7cc9615a57 to be deleted helpers.go:165: Deleted subnet: 7d288385-a35d-4bff-b305-0f7cc9615a57 helpers.go:156: Attempting to delete subnet: f06dac70-c6ab-4a53-8047-33372f39a056 helpers.go:161: Waiting for subnet f06dac70-c6ab-4a53-8047-33372f39a056 to be deleted helpers.go:165: Deleted subnet: f06dac70-c6ab-4a53-8047-33372f39a056 helpers.go:218: Attempting to delete vpc: d03c12ac-a566-4aac-8fa3-b9d079abc4fb helpers.go:223: Deleted vpc: d03c12ac-a566-4aac-8fa3-b9d079abc4fb --- PASS: TestRouteTablesLifecycle (150.62s) PASS Process finished with the exit code 0 Reviewed-by: Artem Lifshits Reviewed-by: Vladimir Vshivkov Reviewed-by: Aloento
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
=== RUN TestRouteTablesList
--- PASS: TestRouteTablesList (0.81s)
=== RUN TestRouteTablesLifecycle
routetables_test.go:46: Attempting to create first vpc: acc-vpc-1-bkM
routetables_test.go:50: Created first vpc: d03c12ac-a566-4aac-8fa3-b9d079abc4fb
routetables_test.go:59: Attempting to create first subnet: acc-subnet-1-1-iTX
routetables_test.go:71: Attempting to create second subnet: acc-subnet-2-1-oXi
routetables_test.go:88: Attempting to create second vpc: acc-vpc-2-d6i
routetables_test.go:92: Created second vpc: f9fc1d04-1a9f-430a-8f54-c54e77341bea
routetables_test.go:101: Attempting to create subnet for second vpc: acc-subnet-1-2-rC8
routetables_test.go:110: Attempting to create peering connection between first and second vpc
routetables_test.go:131: Attempting to create route table
routetables_test.go:145: Attempting to get route table: 20609fa7-61d9-4903-8c43-205fff83e5c8
routetables_test.go:150: Attempting to associate subnets to vpc route table: 20609fa7-61d9-4903-8c43-205fff83e5c8
2023/10/24 17:41:51 Attempting to update VPC route table with peering route: "20609fa7-61d9-4903-8c43-205fff83e5c8"
routetables_test.go:210: Attempting to create cloud server: acc-ecs-2kG
common.go:184: Attempting to create ECSv1
common.go:197: Created ECSv1 instance: d079022f-7e66-418b-ad4a-e6827c4c1896
2023/10/24 17:43:04 Attempting to update VPC route table with ecs route: "20609fa7-61d9-4903-8c43-205fff83e5c8"
routetables_test.go:239: Attempting to disassociate subnets to vpc route table: 20609fa7-61d9-4903-8c43-205fff83e5c8
common.go:203: Attempting to delete ECSv1: d079022f-7e66-418b-ad4a-e6827c4c1896
common.go:220: ECSv1 instance deleted: d079022f-7e66-418b-ad4a-e6827c4c1896
routetables_test.go:124: Attempting to delete vpc peering connection: e645e5e4-522d-4606-b586-e71846e1fc58
helpers.go:156: Attempting to delete subnet: 91cbb672-1622-4b1f-86cf-b987e6dc2c25
helpers.go:161: Waiting for subnet 91cbb672-1622-4b1f-86cf-b987e6dc2c25 to be deleted
helpers.go:165: Deleted subnet: 91cbb672-1622-4b1f-86cf-b987e6dc2c25
helpers.go:218: Attempting to delete vpc: f9fc1d04-1a9f-430a-8f54-c54e77341bea
helpers.go:223: Deleted vpc: f9fc1d04-1a9f-430a-8f54-c54e77341bea
helpers.go:156: Attempting to delete subnet: 7d288385-a35d-4bff-b305-0f7cc9615a57
helpers.go:161: Waiting for subnet 7d288385-a35d-4bff-b305-0f7cc9615a57 to be deleted
helpers.go:165: Deleted subnet: 7d288385-a35d-4bff-b305-0f7cc9615a57
helpers.go:156: Attempting to delete subnet: f06dac70-c6ab-4a53-8047-33372f39a056
helpers.go:161: Waiting for subnet f06dac70-c6ab-4a53-8047-33372f39a056 to be deleted
helpers.go:165: Deleted subnet: f06dac70-c6ab-4a53-8047-33372f39a056
helpers.go:218: Attempting to delete vpc: d03c12ac-a566-4aac-8fa3-b9d079abc4fb
helpers.go:223: Deleted vpc: d03c12ac-a566-4aac-8fa3-b9d079abc4fb
--- PASS: TestRouteTablesLifecycle (150.62s)
PASS
Process finished with the exit code 0