Acceptance: Get rid of `defer` in `ECS` tests (#1556) · opentelekomcloud/terraform-provider-opentelekomcloud@08222e9

Commit

Acceptance: Get rid of defer in ECS tests (#1556)

Acceptance: Get rid of `defer` in `ECS` tests

Summary of the Pull Request
Replace defer for quotas with quotas.Book... calls
PR Checklist

 Refers to: #1538
 Tests added/passed.

Acceptance Steps Performed
=== RUN   TestAccOpenStackAvailabilityZonesV2_basic
=== PAUSE TestAccOpenStackAvailabilityZonesV2_basic
=== CONT  TestAccOpenStackAvailabilityZonesV2_basic
--- PASS: TestAccOpenStackAvailabilityZonesV2_basic (17.77s)
=== RUN   TestAccComputeV2FlavorDataSource_basic
=== PAUSE TestAccComputeV2FlavorDataSource_basic
=== CONT  TestAccComputeV2FlavorDataSource_basic
--- PASS: TestAccComputeV2FlavorDataSource_basic (28.41s)
=== RUN   TestAccComputeV2FlavorDataSource_testQueries
=== PAUSE TestAccComputeV2FlavorDataSource_testQueries
=== CONT  TestAccComputeV2FlavorDataSource_testQueries
--- PASS: TestAccComputeV2FlavorDataSource_testQueries (99.06s)
=== RUN   TestAccComputeV2FloatingIPAssociate_basic
=== PAUSE TestAccComputeV2FloatingIPAssociate_basic
=== CONT  TestAccComputeV2FloatingIPAssociate_basic
--- PASS: TestAccComputeV2FloatingIPAssociate_basic (258.94s)
=== RUN   TestAccComputeV2FloatingIPAssociate_importBasic
=== PAUSE TestAccComputeV2FloatingIPAssociate_importBasic
=== CONT  TestAccComputeV2FloatingIPAssociate_importBasic
--- PASS: TestAccComputeV2FloatingIPAssociate_importBasic (192.57s)
=== RUN   TestAccComputeV2FloatingIPAssociate_fixedIP
=== PAUSE TestAccComputeV2FloatingIPAssociate_fixedIP
=== CONT  TestAccComputeV2FloatingIPAssociate_fixedIP
--- PASS: TestAccComputeV2FloatingIPAssociate_fixedIP (77.58s)
=== RUN   TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork
=== PAUSE TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork
=== CONT  TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork
--- PASS: TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork (109.12s)
=== RUN   TestAccComputeV2FloatingIPAssociate_attachNew
=== PAUSE TestAccComputeV2FloatingIPAssociate_attachNew
=== CONT  TestAccComputeV2FloatingIPAssociate_attachNew
--- PASS: TestAccComputeV2FloatingIPAssociate_attachNew (194.39s)
=== RUN   TestAccComputeV2FloatingIP_basic
--- PASS: TestAccComputeV2FloatingIP_basic (35.08s)
=== RUN   TestAccComputeV2FloatingIP_importBasic
=== PAUSE TestAccComputeV2FloatingIP_importBasic
=== CONT  TestAccComputeV2FloatingIP_importBasic
--- PASS: TestAccComputeV2FloatingIP_importBasic (37.13s)
=== RUN   TestAccComputeV2Instance_basic
=== PAUSE TestAccComputeV2Instance_basic
=== CONT  TestAccComputeV2Instance_basic
--- PASS: TestAccComputeV2Instance_basic (134.64s)
=== RUN   TestAccComputeV2Instance_importBasic
=== PAUSE TestAccComputeV2Instance_importBasic
=== CONT  TestAccComputeV2Instance_importBasic
--- PASS: TestAccComputeV2Instance_importBasic (116.26s)
=== RUN   TestAccComputeV2Instance_multiSecgroup
=== PAUSE TestAccComputeV2Instance_multiSecgroup
=== CONT  TestAccComputeV2Instance_multiSecgroup
--- PASS: TestAccComputeV2Instance_multiSecgroup (157.13s)
=== RUN   TestAccComputeV2Instance_bootFromImage
=== PAUSE TestAccComputeV2Instance_bootFromImage
=== CONT  TestAccComputeV2Instance_bootFromImage
--- PASS: TestAccComputeV2Instance_bootFromImage (71.84s)
=== RUN   TestAccComputeV2Instance_bootFromVolume
=== PAUSE TestAccComputeV2Instance_bootFromVolume
=== CONT  TestAccComputeV2Instance_bootFromVolume
--- PASS: TestAccComputeV2Instance_bootFromVolume (112.78s)
=== RUN   TestAccComputeV2Instance_importBootFromVolumeImage
=== PAUSE TestAccComputeV2Instance_importBootFromVolumeImage
=== CONT  TestAccComputeV2Instance_importBootFromVolumeImage
--- PASS: TestAccComputeV2Instance_importBootFromVolumeImage (72.45s)
=== RUN   TestAccComputeV2Instance_changeFixedIP
=== PAUSE TestAccComputeV2Instance_changeFixedIP
=== CONT  TestAccComputeV2Instance_changeFixedIP
--- PASS: TestAccComputeV2Instance_changeFixedIP (60.07s)
=== RUN   TestAccComputeV2Instance_bootFromVolumeVolume
=== PAUSE TestAccComputeV2Instance_bootFromVolumeVolume
=== CONT  TestAccComputeV2Instance_bootFromVolumeVolume
--- PASS: TestAccComputeV2Instance_bootFromVolumeVolume (76.76s)
=== RUN   TestAccComputeV2Instance_stopBeforeDestroy
=== PAUSE TestAccComputeV2Instance_stopBeforeDestroy
=== CONT  TestAccComputeV2Instance_stopBeforeDestroy
--- PASS: TestAccComputeV2Instance_stopBeforeDestroy (63.90s)
=== RUN   TestAccComputeV2Instance_metadata
=== PAUSE TestAccComputeV2Instance_metadata
=== CONT  TestAccComputeV2Instance_metadata
--- PASS: TestAccComputeV2Instance_metadata (157.02s)
=== RUN   TestAccComputeV2Instance_timeout
=== PAUSE TestAccComputeV2Instance_timeout
=== CONT  TestAccComputeV2Instance_timeout
--- PASS: TestAccComputeV2Instance_timeout (66.96s)
=== RUN   TestAccComputeV2Instance_autoRecovery
=== PAUSE TestAccComputeV2Instance_autoRecovery
=== CONT  TestAccComputeV2Instance_autoRecovery
--- PASS: TestAccComputeV2Instance_autoRecovery (103.06s)
=== RUN   TestAccComputeV2Instance_crazyNICs
=== PAUSE TestAccComputeV2Instance_crazyNICs
=== CONT  TestAccComputeV2Instance_crazyNICs
--- PASS: TestAccComputeV2Instance_crazyNICs (184.82s)
=== RUN   TestAccComputeV2Instance_initialStateActive
=== PAUSE TestAccComputeV2Instance_initialStateActive
=== CONT  TestAccComputeV2Instance_initialStateActive
--- PASS: TestAccComputeV2Instance_initialStateActive (139.45s)
=== RUN   TestAccComputeV2Instance_initialStateShutoff
=== PAUSE TestAccComputeV2Instance_initialStateShutoff
=== CONT  TestAccComputeV2Instance_initialStateShutoff
--- PASS: TestAccComputeV2Instance_initialStateShutoff (181.14s)
=== RUN   TestAccComputeV2Keypair_basic
=== PAUSE TestAccComputeV2Keypair_basic
=== CONT  TestAccComputeV2Keypair_basic
--- PASS: TestAccComputeV2Keypair_basic (21.71s)
=== RUN   TestAccComputeV2Keypair_importBasic
=== PAUSE TestAccComputeV2Keypair_importBasic
=== CONT  TestAccComputeV2Keypair_importBasic
--- PASS: TestAccComputeV2Keypair_importBasic (24.53s)
=== RUN   TestAccComputeV2Keypair_shared
=== PAUSE TestAccComputeV2Keypair_shared
=== CONT  TestAccComputeV2Keypair_shared
--- PASS: TestAccComputeV2Keypair_shared (38.27s)
=== RUN   TestAccComputeV2Keypair_private
=== PAUSE TestAccComputeV2Keypair_private
=== CONT  TestAccComputeV2Keypair_private
--- PASS: TestAccComputeV2Keypair_private (20.37s)
=== RUN   TestAccComputeV2SecGroup_basic
=== PAUSE TestAccComputeV2SecGroup_basic
=== CONT  TestAccComputeV2SecGroup_basic
--- PASS: TestAccComputeV2SecGroup_basic (35.72s)
=== RUN   TestAccComputeV2SecGroup_importBasic
=== PAUSE TestAccComputeV2SecGroup_importBasic
=== CONT  TestAccComputeV2SecGroup_importBasic
--- PASS: TestAccComputeV2SecGroup_importBasic (40.87s)
=== RUN   TestAccComputeV2SecGroup_update
=== PAUSE TestAccComputeV2SecGroup_update
=== CONT  TestAccComputeV2SecGroup_update
--- PASS: TestAccComputeV2SecGroup_update (54.76s)
=== RUN   TestAccComputeV2SecGroup_groupID
    resource_opentelekomcloud_compute_secgroup_v2_test.go:85: this test is not a stable one
--- SKIP: TestAccComputeV2SecGroup_groupID (0.00s)

Test ignored.
=== RUN   TestAccComputeV2SecGroup_self
--- PASS: TestAccComputeV2SecGroup_self (34.54s)
=== RUN   TestAccComputeV2SecGroup_icmpZero
=== PAUSE TestAccComputeV2SecGroup_icmpZero
=== CONT  TestAccComputeV2SecGroup_icmpZero
--- PASS: TestAccComputeV2SecGroup_icmpZero (35.03s)
=== RUN   TestAccComputeV2SecGroup_timeout
=== PAUSE TestAccComputeV2SecGroup_timeout
=== CONT  TestAccComputeV2SecGroup_timeout
--- PASS: TestAccComputeV2SecGroup_timeout (35.64s)
=== RUN   TestAccComputeV2ServerGroup_basic
=== PAUSE TestAccComputeV2ServerGroup_basic
=== CONT  TestAccComputeV2ServerGroup_basic
--- PASS: TestAccComputeV2ServerGroup_basic (20.15s)
=== RUN   TestAccComputeV2ServerGroup_import
=== PAUSE TestAccComputeV2ServerGroup_import
=== CONT  TestAccComputeV2ServerGroup_import
--- PASS: TestAccComputeV2ServerGroup_import (23.43s)
=== RUN   TestAccComputeV2ServerGroup_affinity
=== PAUSE TestAccComputeV2ServerGroup_affinity
=== CONT  TestAccComputeV2ServerGroup_affinity
=== CONT  TestAccComputeV2ServerGroup_affinity
    resource_opentelekomcloud_compute_servergroup_v2_test.go:66: Step 1/1 error: Check failed: Check 3/3 error: instance ea48d860-2f46-439e-a556-a33c67b88a7c is not part of Server Group a45636c8-edd2-4038-89e0-3ab0544378f6
--- FAIL: TestAccComputeV2ServerGroup_affinity (48.51s)

=== RUN   TestAccComputeV2VolumeAttach_basic
=== PAUSE TestAccComputeV2VolumeAttach_basic
=== CONT  TestAccComputeV2VolumeAttach_basic
--- PASS: TestAccComputeV2VolumeAttach_basic (124.66s)
=== RUN   TestAccComputeV2VolumeAttach_importBasic
=== PAUSE TestAccComputeV2VolumeAttach_importBasic
=== CONT  TestAccComputeV2VolumeAttach_importBasic
--- PASS: TestAccComputeV2VolumeAttach_importBasic (131.77s)
=== RUN   TestAccComputeV2VolumeAttach_device
=== PAUSE TestAccComputeV2VolumeAttach_device
=== CONT  TestAccComputeV2VolumeAttach_device
--- PASS: TestAccComputeV2VolumeAttach_device (125.57s)
=== RUN   TestAccComputeV2VolumeAttach_timeout
=== PAUSE TestAccComputeV2VolumeAttach_timeout
=== CONT  TestAccComputeV2VolumeAttach_timeout
--- PASS: TestAccComputeV2VolumeAttach_timeout (184.27s)
=== RUN   TestAccEcsV1InstanceBasic
=== PAUSE TestAccEcsV1InstanceBasic
=== CONT  TestAccEcsV1InstanceBasic
--- PASS: TestAccEcsV1InstanceBasic (201.66s)
=== RUN   TestAccEcsV1Instance_import
=== PAUSE TestAccEcsV1Instance_import
=== CONT  TestAccEcsV1Instance_import
--- PASS: TestAccEcsV1Instance_import (163.80s)
=== RUN   TestAccEcsV1InstanceDiskTypeValidation
=== PAUSE TestAccEcsV1InstanceDiskTypeValidation
=== CONT  TestAccEcsV1InstanceDiskTypeValidation
--- PASS: TestAccEcsV1InstanceDiskTypeValidation (17.76s)
=== RUN   TestAccEcsV1InstanceVPCValidation
=== PAUSE TestAccEcsV1InstanceVPCValidation
=== CONT  TestAccEcsV1InstanceVPCValidation
--- PASS: TestAccEcsV1InstanceVPCValidation (210.48s)
=== RUN   TestAccEcsV1InstanceEncryption
=== PAUSE TestAccEcsV1InstanceEncryption
=== CONT  TestAccEcsV1InstanceEncryption
--- PASS: TestAccEcsV1InstanceEncryption (155.85s)
FAIL
FAIL	github.com/opentelekomcloud/terraform-provider-opentelekomcloud/opentelekomcloud/acceptance/ecs	433.303s

Process finished with the exit code 1


There is an issue for the failed test: #1555

Reviewed-by: Vladimir Vshivkov <None>
Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: None <None>

Loading branch information

outcatcher committed Nov 29, 2021

1 parent d79e0a3 commit 08222e9

opentelekomcloud/acceptance/ecs/data_source_opentelekomcloud_compute_flavor_v2_test.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -34,6 +34,8 @@ func TestAccComputeV2FlavorDataSource_basic(t *testing.T) { @@
     }
     func TestAccComputeV2FlavorDataSource_testQueries(t *testing.T) {
+    	t.Parallel()
     	resource.Test(t, resource.TestCase{
     		PreCheck:          func() { common.TestAccPreCheck(t) },
     		ProviderFactories: common.TestAccProviderFactories,
@@ Expand Down @@