Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMS - Topic retention validation too restrictive #2063

Closed
deibl opened this issue Jan 27, 2023 · 2 comments
Closed

DMS - Topic retention validation too restrictive #2063

deibl opened this issue Jan 27, 2023 · 2 comments
Assignees
@artem-lifshits
Labels
accepted

Comments

@deibl
Copy link

deibl commented Jan 27, 2023 •
edited

Terraform provider version

1.32.1

Affected Resource(s)

opentelekomcloud_dms_topic_v1

Terraform Configuration Files

resource "opentelekomcloud_dms_topic_v1" "topic" {
  ...
  retention_time   = 720
}

Debug Output/Panic Output

expected retention_time to be in the range (1 - 168), got 720

Steps to Reproduce

set retention_time to value > 168

Expected Behavior

retention_time up to 720 should work (as this is possible via UI)

Actual Behavior

expected retention_time to be in the range (1 - 168), got 720
@artem-lifshits artem-lifshits self-assigned this Jan 27, 2023
@artem-lifshits
Copy link
Member

Looks like maximum retention time has changed since this resource was first introduced.
Will be fixed on next release.

@artem-lifshits artem-lifshits mentioned this issue Feb 1, 2023
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Feb 2, 2023
@artem-lifshits
[DMS]: Fix retention time validation for `opentelekomcloud_dms_topic_…
9ce5f17 
…v1` (#2066)

[DMS]: Fix retention time validation for `opentelekomcloud_dms_topic_v1`

Summary of the Pull Request
DMS topic parameter scope was changed, validation should be changed along with it
PR Checklist

 Refers to: #2063
 Tests passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestAccDmsTopicsV1_basic
--- PASS: TestAccDmsTopicsV1_basic (628.17s)
PASS


Process finished with the exit code 0

Reviewed-by: Anton Sidelnikov
Reviewed-by: Vladimir Vshivkov
Reviewed-by: Ilia Bakhterev
@artem-lifshits
Copy link
Member

Hello @deibl retention time was fixed in latest release, please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-lifshits artem-lifshits

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deibl @artem-lifshits