Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIP Bandwidth support #716

Closed
gtema opened this issue Nov 20, 2020 · 8 comments · Fixed by #1561
Closed

FIP Bandwidth support #716

gtema opened this issue Nov 20, 2020 · 8 comments · Fixed by #1561
Assignees
@outcatcher
Labels
new-data-source new-resource SDK Requires SDK changes
Milestone
v1.27.0

Comments

@gtema
Copy link
Member

gtema commented Nov 20, 2020

Management of the FIP bandwidth is required. Sadly this is another example of a version mix (1 + 2)

https://docs.otc.t-systems.com/api/eip/eip_apisharedbandwidth_0000.html
and
https://docs.otc.t-systems.com/api/eip/eip_apiBandwidth_0000.html
@outcatcher
Copy link
Contributor

@gtema
opentelekomcloud_vpc_eip_v1 provides bandwidth configuration for EIP. Do you need some other features?

@gtema
Copy link
Member Author

gtema commented Nov 20, 2020

oh cool, haven't noticed that.
Is size update supported?
That would be already fine. Perhaps we need then possibility to manage shared bandwidth (allocate/attach/detach) so that use of opentelekomcloud_networking_floatingip_v2 can remain if desired

@outcatcher
Copy link
Contributor

Yes, there is bandwidth.Update on size and name update. Bandwidth v2 is not implemented. I suppose, were should implement opentelekomcloud_network_bandwidth_v2 in this case (both r/ and d/)

@niuzhenguo
Copy link
Collaborator

Do you mean shared bandwidth here? https://github.com/huaweicloud/terraform-provider-huaweicloud/blob/master/huaweicloud/resource_huaweicloud_vpc_bandwidth.go

@outcatcher outcatcher added this to the v1.22.0 milestone Nov 20, 2020
@outcatcher outcatcher self-assigned this Nov 24, 2020
@outcatcher outcatcher added the SDK Requires SDK changes label Nov 24, 2020
@outcatcher outcatcher mentioned this issue Nov 24, 2020
Merged
3 tasks
@outcatcher
Copy link
Contributor

Bandwidth v2 API is missing now, only data source will be implemented in this release

@outcatcher outcatcher added the otc-issue Blocked by OTC issues label Nov 24, 2020
@outcatcher outcatcher removed this from the v1.21.6 milestone Nov 24, 2020
otc-zuul bot pushed a commit that referenced this issue Nov 24, 2020
@outcatcher
Add opentelekomcloud_vpc_bandwidth data source (#719)
a044dbd 
Add `opentelekomcloud_vpc_bandwidth` data source

Summary of the Pull Request
Add opentelekomcloud_vpc_bandwidth data source
PR Checklist

 Refers to: #716
 Tests added/passed.
 Documentation updated.

Acceptance Steps Performed
=== RUN   TestAccBandWidthDataSource_basic
=== PAUSE TestAccBandWidthDataSource_basic
=== CONT  TestAccBandWidthDataSource_basic
--- PASS: TestAccBandWidthDataSource_basic (24.50s)
PASS

Process finished with exit code 0

Reviewed-by: None <None>
Reviewed-by: Anton Sidelnikov <None>
Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
@outcatcher outcatcher mentioned this issue Nov 24, 2020
Closed
3 tasks
@outcatcher
Copy link
Contributor

Jira reference: https://jira.tsi-dev.otc-service.com/browse/ONS-3912

@outcatcher outcatcher removed their assignment Jan 18, 2021
@lego963 lego963 mentioned this issue Nov 10, 2021
Closed
@outcatcher outcatcher removed the otc-issue Blocked by OTC issues label Nov 18, 2021
@outcatcher
Copy link
Contributor

Bandwidth API is available on PROD now

@outcatcher outcatcher added this to the v1.26.3 milestone Nov 18, 2021
@outcatcher outcatcher self-assigned this Nov 24, 2021
@outcatcher outcatcher mentioned this issue Nov 24, 2021
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Nov 25, 2021
@outcatcher
[VPC] Add vpc_bandwidth_v2 resource (#1548)
73eaa0e 
[VPC] Add `vpc_bandwidth_v2` resource

Summary of the Pull Request
Add resource/opentelekomcloud_vpc_bandwidth_v2
Part of #716 (still need a resource for associating)
PR Checklist

 Refers to: #716
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestBandwidthV2_basic
=== PAUSE TestBandwidthV2_basic
=== CONT  TestBandwidthV2_basic
--- PASS: TestBandwidthV2_basic (34.25s)
=== RUN   TestBandwidthV2_import
=== PAUSE TestBandwidthV2_import
=== CONT  TestBandwidthV2_import
--- PASS: TestBandwidthV2_import (22.37s)
PASS

Process finished with the exit code 0

Reviewed-by: None <None>
Reviewed-by: Vladimir Vshivkov <None>
Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
@outcatcher outcatcher mentioned this issue Nov 25, 2021
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Nov 25, 2021
@outcatcher
[VPC] Add vpc_bandwidth_associate_v2 resource (#1549)
5e9136e 
[VPC] Add `vpc_bandwidth_associate_v2` resource

Summary of the Pull Request
Add new resource opentelekomcloud_vpc_bandwidth_associate_v2
Fix minor problems with opentelekomcloud_vpc_bandwidth_v2 doc and RN
Part of #716 (still need a data source)
PR Checklist

 Refers to: #716
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestBandwidthAssociateV2_basic
=== PAUSE TestBandwidthAssociateV2_basic
=== CONT  TestBandwidthAssociateV2_basic
--- PASS: TestBandwidthAssociateV2_basic (71.67s)
=== RUN   TestBandwidthAssociateV2_EIPv1
=== PAUSE TestBandwidthAssociateV2_EIPv1
=== CONT  TestBandwidthAssociateV2_EIPv1
--- PASS: TestBandwidthAssociateV2_EIPv1 (88.06s)
=== RUN   TestBandwidthAssociateV2_import
=== PAUSE TestBandwidthAssociateV2_import
=== CONT  TestBandwidthAssociateV2_import
--- PASS: TestBandwidthAssociateV2_import (46.76s)
PASS

Process finished with the exit code 0

Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: None <None>
Reviewed-by: Vladimir Vshivkov <None>
@outcatcher
Copy link
Contributor

Move data source to the next milestone

@outcatcher outcatcher modified the milestones: v1.26.3, v1.26.4 Nov 25, 2021
@outcatcher outcatcher mentioned this issue Nov 30, 2021
Merged
5 tasks
@otc-zuul otc-zuul bot closed this as completed in #1561 Nov 30, 2021
otc-zuul bot pushed a commit that referenced this issue Nov 30, 2021
@outcatcher
[VPC] Add vpc_bandwidth_v2 data source (#1561)
f0575ce 
[VPC] Add `vpc_bandwidth_v2` data source

Summary of the Pull Request
Create opentelekomcloud_vpc_bandwidth_v2 data source
Deprecate opentelekomcloud_vpc_bandwidth data source
Closes #716
PR Checklist

 Refers to: #716
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestAccBandWidthV2DataSource_basic
=== PAUSE TestAccBandWidthV2DataSource_basic
=== CONT  TestAccBandWidthV2DataSource_basic
--- PASS: TestAccBandWidthV2DataSource_basic (20.10s)
PASS

Process finished with the exit code 0

Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@outcatcher outcatcher

Labels
new-data-source new-resource SDK Requires SDK changes
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging a pull request may close this issue.

[VPC] Add vpc_bandwidth_v2 data source opentelekomcloud/terraform-provider-opentelekomcloud
3 participants
@niuzhenguo @outcatcher @gtema