Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCE] Fix authenticating_proxy cluster auth mode #1418

Merged
merged 1 commit into from Sep 22, 2021
Merged

[CCE] Fix authenticating_proxy cluster auth mode #1418

merged 1 commit into from Sep 22, 2021

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Sep 22, 2021 •
edited

Summary of the Pull Request

Make authenticating_proxy_ca deprecated.

Add authenticating_proxy argument containing all ca, cert, and private_key for configuring authenticating proxy auth mode.

Fix #1417

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccCCEClusterV3_proxyAuth
--- PASS: TestAccCCEClusterV3_proxyAuth (427.92s)
PASS

Process finished with the exit code 0

@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team September 22, 2021 07:57
@outcatcher outcatcher marked this pull request as ready for review September 22, 2021 07:57
lego963
lego963 previously approved these changes Sep 22, 2021
View reviewed changes
otc-zuul[bot]
otc-zuul bot previously approved these changes Sep 22, 2021
View reviewed changes
@outcatcher
[CCE] Fix authenticating_proxy cluster auth mode
8bf46f4 
Make `authenticating_proxy_ca` deprecated.

Add `authenticating_proxy` argument containing all `ca`, `cert`,
and `private_key` for configuring authenticating proxy auth mode.
@outcatcher outcatcher dismissed stale reviews from otc-zuul and lego963 via 8bf46f4 September 22, 2021 08:08
@outcatcher outcatcher added the gate Merge PR label Sep 22, 2021
@otc-zuul
Copy link

otc-zuul bot commented Sep 22, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit f15da67 into devel Sep 22, 2021
@otc-zuul otc-zuul bot deleted the fix/cce-auth-proxy branch September 22, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@vladimirvshivkov vladimirvshivkov vladimirvshivkov approved these changes

@otc-zuul otc-zuul[bot] otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CCE] Error creating cluster with authenticating_proxy auth mode
4 participants
@outcatcher @lego963 @vladimirvshivkov @anton-sidelnikov