Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNS] Add data_source/opentelekomcloud_dns_nameserver_v2 #1715

Merged
merged 1 commit into from Apr 27, 2022
Merged

[DNS] Add data_source/opentelekomcloud_dns_nameserver_v2 #1715

merged 1 commit into from Apr 27, 2022

Conversation

vladimirvshivkov
Copy link
Contributor

@vladimirvshivkov vladimirvshivkov commented Apr 26, 2022 •
edited

Summary of the Pull Request

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccDNSV2NameserverDataSource_basic
--- PASS: TestAccDNSV2NameserverDataSource_basic (43.78s)
PASS

Process finished with exit code 0

@vladimirvshivkov vladimirvshivkov added this to the v1.29.2 milestone Apr 26, 2022
@vladimirvshivkov vladimirvshivkov changed the title [DNS] Added data source data_source/opentelekomcloud_dns_nameserver_v2 to query DNS nameservers [DNS] Added data_source/opentelekomcloud_dns_nameserver_v2 Apr 26, 2022
@vladimirvshivkov vladimirvshivkov changed the title [DNS] Added data_source/opentelekomcloud_dns_nameserver_v2 [DNS] Add data_source/opentelekomcloud_dns_nameserver_v2 Apr 26, 2022
@vladimirvshivkov vladimirvshivkov marked this pull request as ready for review April 27, 2022 09:46
outcatcher
outcatcher suggested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to name resource opentelekomcloud_dns_nameservers_v2, pointing to the fact it returns name server list, not a single name server?

opentelekomcloud/acceptance/dns/data_source_opentelekomcloud_dns_nameserver_v2_test.go Outdated Show resolved Hide resolved
opentelekomcloud/provider.go Outdated Show resolved Hide resolved
opentelekomcloud/services/dns/data_source_opentelekomcloud_dns_nameserver_v2.go Outdated Show resolved Hide resolved
releasenotes/notes/dns-nameserver-01dd4b5a9f600106.yaml Outdated Show resolved Hide resolved
This was linked to issues Apr 27, 2022
"masters" attribute is always empty for opentelekomcloud_dns_zone_v2 public zone #1703
Closed
DNS: Retrieve nameservers #1704
Closed
@vladimirvshivkov vladimirvshivkov added the gate Merge PR label Apr 27, 2022
@otc-zuul
Copy link

otc-zuul bot commented Apr 27, 2022

Build succeeded.

✔️ build-otc-releasenotes SUCCESS in 8m 56s
✔️ otc-golangci-lint SUCCESS in 8m 41s
✔️ golang-make-test SUCCESS in 9m 01s
✔️ golang-make-vet SUCCESS in 8m 16s
✔️ tflint SUCCESS in 8m 02s
✔️ goreleaser-build SUCCESS in 8m 34s

@otc-zuul otc-zuul bot merged commit 9980e7b into devel Apr 27, 2022
@otc-zuul otc-zuul bot deleted the dns_nameservers branch April 27, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@lego963 lego963 Awaiting requested review from lego963

@anton-sidelnikov anton-sidelnikov Awaiting requested review from anton-sidelnikov

Assignees
No one assigned
Labels
dependencies gate Merge PR
Projects
None yet
Milestone
v1.29.2
Development

Successfully merging this pull request may close these issues.

DNS: Retrieve nameservers "masters" attribute is always empty for opentelekomcloud_dns_zone_v2 public zone
2 participants
@vladimirvshivkov @outcatcher