Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECS] Add disk_id in schema of ecs_instance_v1 #1801

Merged
merged 3 commits into from Jul 7, 2022
Merged

[ECS] Add disk_id in schema of ecs_instance_v1 #1801

merged 3 commits into from Jul 7, 2022

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Jul 7, 2022 •
edited

Summary of the Pull Request

Return IDs of data_disks and system_disk in resource/opentelekomcloud_ecs_instance_v1

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccEcsV1InstanceBasic
=== PAUSE TestAccEcsV1InstanceBasic
=== CONT  TestAccEcsV1InstanceBasic
--- PASS: TestAccEcsV1InstanceBasic (254.68s)
PASS


Process finished with the exit code 0

@lego963 lego963 added the gate Merge PR label Jul 7, 2022
@anton-sidelnikov anton-sidelnikov added gate Merge PR and removed gate Merge PR labels Jul 7, 2022
@otc-zuul
Copy link

otc-zuul bot commented Jul 7, 2022

Build succeeded.

✔️ build-otc-releasenotes SUCCESS in 2m 34s
✔️ otc-golangci-lint SUCCESS in 2m 29s
✔️ golang-make-test SUCCESS in 3m 03s
✔️ golang-make-vet SUCCESS in 2m 29s
✔️ tflint SUCCESS in 1m 38s
✔️ goreleaser-build SUCCESS in 8m 17s

@otc-zuul otc-zuul bot merged commit 8058bcb into devel Jul 7, 2022
@otc-zuul otc-zuul bot deleted the add-volume-id branch July 7, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lego963 @anton-sidelnikov @artem-lifshits