Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KMS] Add allow_cancel_deletion in schema of kms_key_v1 #1806

Merged
merged 6 commits into from Jul 13, 2022
Merged

[KMS] Add allow_cancel_deletion in schema of kms_key_v1 #1806

merged 6 commits into from Jul 13, 2022

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jul 12, 2022 •
edited

Summary of the Pull Request

Added ability to canceling the Scheduled Deletion of a CMK

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccKmsKeyV1_basic
--- PASS: TestAccKmsKeyV1_basic (83.71s)
=== RUN   TestAccKmsKey_isEnabled
--- PASS: TestAccKmsKey_isEnabled (115.14s)
=== RUN   TestAccKmsKey_rotation
--- PASS: TestAccKmsKey_rotation (50.18s)
=== RUN   TestAccKmsKey_cancelDeletion
--- PASS: TestAccKmsKey_cancelDeletion(51.07s)
PASS

Process finished with the exit code 0

@anton-sidelnikov anton-sidelnikov self-assigned this Jul 12, 2022
@anton-sidelnikov anton-sidelnikov changed the title [KMS] Add desired_state in schema of kms_key_v1 [KMS] Add desired_state in schema of kms_key_v1 Jul 12, 2022
artem-lifshits
artem-lifshits previously approved these changes Jul 12, 2022
View reviewed changes
vladimirvshivkov
vladimirvshivkov requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@vladimirvshivkov vladimirvshivkov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desired state its kinda weird arg for terraform's declarative code

@vladimirvshivkov vladimirvshivkov added the gate Merge PR label Jul 13, 2022
@otc-zuul
Copy link

otc-zuul bot commented Jul 13, 2022

Build succeeded.

✔️ build-otc-releasenotes SUCCESS in 2m 24s
✔️ otc-golangci-lint SUCCESS in 2m 58s
✔️ golang-make-test SUCCESS in 2m 48s
✔️ golang-make-vet SUCCESS in 2m 30s
✔️ tflint SUCCESS in 1m 37s
✔️ goreleaser-build SUCCESS in 7m 50s

@otc-zuul otc-zuul bot merged commit aadbd25 into devel Jul 13, 2022
@otc-zuul otc-zuul bot deleted the kms-cancel-deletion branch July 13, 2022 10:55
@vladimirvshivkov vladimirvshivkov added this to the v1.30.0 milestone Jul 14, 2022
@vladimirvshivkov vladimirvshivkov linked an issue Jul 14, 2022 that may be closed by this pull request
kms_key_v1: Please check state before trying to create a key #1804
Closed
@anton-sidelnikov anton-sidelnikov changed the title [KMS] Add desired_state in schema of kms_key_v1 [KMS] Add allow_cancel_deletion in schema of kms_key_v1 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirvshivkov vladimirvshivkov vladimirvshivkov approved these changes

@artem-lifshits artem-lifshits artem-lifshits left review comments

@lego963 lego963 Awaiting requested review from lego963

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
dependencies documentation enhancement gate Merge PR
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

kms_key_v1: Please check state before trying to create a key
3 participants
@anton-sidelnikov @vladimirvshivkov @artem-lifshits