Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KMS] fix kms deletion with enabled rotation #1823

Merged
merged 3 commits into from Jul 19, 2022
Merged

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jul 19, 2022

Summary of the Pull Request

When reenable key, which was created with rotation: {"error":{"error_msg":"The rotation state of key is not disabled.","error_code":"KMS.2901"}}.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccKmsKeyV1_basic
--- PASS: TestAccKmsKeyV1_basic (83.19s)
=== RUN   TestAccKmsKey_isEnabled
--- PASS: TestAccKmsKey_isEnabled (116.61s)
=== RUN   TestAccKmsKey_rotation
--- PASS: TestAccKmsKey_rotation (51.10s)
=== RUN   TestAccKmsKey_cancelDeletion
--- PASS: TestAccKmsKey_cancelDeletion (50.83s)
=== RUN   TestAccKmsKey_cancelDeletionWithRotation
--- PASS: TestAccKmsKey_cancelDeletionWithRotation (52.38s)
PASS


Process finished with the exit code 0

@anton-sidelnikov anton-sidelnikov self-assigned this Jul 19, 2022
@anton-sidelnikov anton-sidelnikov added this to In progress in Upstream via automation Jul 19, 2022
@anton-sidelnikov anton-sidelnikov added this to the v1.30.1 milestone Jul 19, 2022
@vladimirvshivkov vladimirvshivkov added the gate Merge PR label Jul 19, 2022
@otc-zuul
Copy link

otc-zuul bot commented Jul 19, 2022

Build succeeded.

✔️ build-otc-releasenotes SUCCESS in 2m 36s
✔️ otc-golangci-lint SUCCESS in 2m 48s
✔️ golang-make-test SUCCESS in 3m 17s
✔️ golang-make-vet SUCCESS in 2m 30s
✔️ tflint SUCCESS in 1m 35s
✔️ goreleaser-build SUCCESS in 7m 12s

@otc-zuul otc-zuul bot merged commit 5368baf into devel Jul 19, 2022
Upstream automation moved this from In progress to Done Jul 19, 2022
@otc-zuul otc-zuul bot deleted the fix-kms-rotation branch July 19, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gate Merge PR
Projects
Upstream
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants