Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNS] TXT recordset quotes handling #1829

Merged
merged 3 commits into from Jul 22, 2022
Merged

[DNS] TXT recordset quotes handling #1829

merged 3 commits into from Jul 22, 2022

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jul 22, 2022

Summary of the Pull Request

API wants TXT recordset to be extra quoted

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccDNSV2RecordSet_basic
--- PASS: TestAccDNSV2RecordSet_basic (96.48s)
=== RUN   TestAccDNSV2RecordSet_unDotted
--- PASS: TestAccDNSV2RecordSet_unDotted (56.72s)
=== RUN   TestAccDNSV2RecordSet_childFirst
--- PASS: TestAccDNSV2RecordSet_childFirst (90.70s)
=== RUN   TestAccDNSV2RecordSet_readTTL
--- PASS: TestAccDNSV2RecordSet_readTTL (55.84s)
=== RUN   TestAccDNSV2RecordSet_timeout
--- PASS: TestAccDNSV2RecordSet_timeout (57.07s)
=== RUN   TestAccDNSV2RecordSet_shared
--- PASS: TestAccDNSV2RecordSet_shared (114.09s)
=== RUN   TestAccDNSV2RecordSet_txt
--- PASS: TestAccDNSV2RecordSet_txt (90.05s)
PASS

Process finished with the exit code 0

@anton-sidelnikov
Copy link
Member Author

added test results

@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Jul 22, 2022
@otc-zuul
Copy link

otc-zuul bot commented Jul 22, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/be04624754504d6f9f405a034f892c82

✔️ build-otc-releasenotes SUCCESS in 4m 19s
✔️ otc-golangci-lint SUCCESS in 2m 44s
✔️ golang-make-test SUCCESS in 3m 50s
✔️ golang-make-vet SUCCESS in 2m 39s
✔️ tflint SUCCESS in 1m 36s
✔️ goreleaser-build SUCCESS in 7m 50s

@otc-zuul otc-zuul bot merged commit 4285652 into devel Jul 22, 2022
@otc-zuul otc-zuul bot deleted the fix-txt-recordsets branch July 22, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants