Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CES] use client from ctx in opentelekomcloud_ces_alarmrule #1847

Merged
merged 2 commits into from Jul 29, 2022
Merged

[CES] use client from ctx in opentelekomcloud_ces_alarmrule #1847

merged 2 commits into from Jul 29, 2022

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jul 29, 2022 •
edited

Summary of the Pull Request

Use client from ctx in opentelekomcloud_ces_alarmrule

PR Checklist

Acceptance Steps Performed

=== RUN   TestCESAlarmRule_basic
=== PAUSE TestCESAlarmRule_basic
=== CONT  TestCESAlarmRule_basic
--- PASS: TestCESAlarmRule_basic (124.12s)
PASS


Process finished with the exit code 0

@anton-sidelnikov anton-sidelnikov self-assigned this Jul 29, 2022
@anton-sidelnikov anton-sidelnikov added this to In progress in Upstream via automation Jul 29, 2022
@vladimirvshivkov
Copy link
Contributor

will this work for issue #1844 ?

@anton-sidelnikov
Copy link
Member Author

will this work for issue #1844 ?

i think yes

@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Jul 29, 2022
@otc-zuul
Copy link

otc-zuul bot commented Jul 29, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/f9a5490c8681407e8bdf5caf03f8e9d1

✔️ build-otc-releasenotes SUCCESS in 4m 29s
✔️ otc-golangci-lint SUCCESS in 2m 45s
✔️ golang-make-test SUCCESS in 3m 15s
✔️ golang-make-vet SUCCESS in 2m 26s
✔️ tflint SUCCESS in 1m 47s
✔️ goreleaser-build SUCCESS in 8m 15s

@otc-zuul otc-zuul bot merged commit 7c8afdf into devel Jul 29, 2022
Upstream automation moved this from In progress to Done Jul 29, 2022
@otc-zuul otc-zuul bot deleted the throttle-alarmrule branch July 29, 2022 07:03
@lego963 lego963 mentioned this pull request Jul 29, 2022
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@vladimirvshivkov vladimirvshivkov vladimirvshivkov approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@Aloento Aloento Awaiting requested review from Aloento

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
enhancement gate Merge PR
Projects
Upstream
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anton-sidelnikov @vladimirvshivkov @lego963 @artem-lifshits