Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VPC] Use client from ctx in vpc_eip_v1 #1849

Merged
merged 2 commits into from Jul 29, 2022
Merged

[VPC] Use client from ctx in vpc_eip_v1 #1849

merged 2 commits into from Jul 29, 2022

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Jul 29, 2022 •
edited

Summary of the Pull Request

Use client from ctx in resource/opentelekomcloud_vcp_eip_v1

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccVpcV1EIP_basic
=== PAUSE TestAccVpcV1EIP_basic
=== CONT  TestAccVpcV1EIP_basic
--- PASS: TestAccVpcV1EIP_basic (95.95s)
=== RUN   TestAccVpcV1EIP_timeout
=== PAUSE TestAccVpcV1EIP_timeout
=== CONT  TestAccVpcV1EIP_timeout
--- PASS: TestAccVpcV1EIP_timeout (57.82s)
PASS


Process finished with the exit code 0

@lego963 lego963 marked this pull request as ready for review July 29, 2022 09:41
@lego963 lego963 mentioned this pull request Jul 29, 2022
Closed
32 tasks
@Aloento Aloento added the gate Merge PR label Jul 29, 2022
@otc-zuul
Copy link

otc-zuul bot commented Jul 29, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/85b5ca19be7849db873c9e9cfbee9d91

✔️ build-otc-releasenotes SUCCESS in 3m 21s
✔️ otc-golangci-lint SUCCESS in 3m 00s
✔️ golang-make-test SUCCESS in 3m 22s
✔️ golang-make-vet SUCCESS in 2m 45s
✔️ tflint SUCCESS in 1m 50s
✔️ goreleaser-build SUCCESS in 7m 53s

@otc-zuul otc-zuul bot merged commit ed91e88 into devel Jul 29, 2022
@otc-zuul otc-zuul bot deleted the eip-ctx-client branch July 29, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aloento Aloento Aloento approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@artem-lifshits artem-lifshits Awaiting requested review from artem-lifshits

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lego963 @Aloento @anton-sidelnikov