Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDS] Use client from ctx in rds_instance_v3 #1873

Merged
merged 3 commits into from Aug 15, 2022
Merged

[RDS] Use client from ctx in rds_instance_v3 #1873

merged 3 commits into from Aug 15, 2022

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Aug 5, 2022 •
edited

Summary of the Pull Request

PR Checklist

Acceptance Steps Performed


=== RUN   TestAccRdsInstanceV3RestoreBackup
--- PASS: TestAccRdsInstanceV3RestoreBackup (1116.80s)
=== RUN   TestAccRdsInstanceV3ElasticIP
--- PASS: TestAccRdsInstanceV3ElasticIP (427.52s)
=== RUN   TestAccRdsInstanceV3OptionalParams
--- PASS: TestAccRdsInstanceV3OptionalParams (367.78s)
=== RUN   TestAccRdsInstanceV3Backup
--- PASS: TestAccRdsInstanceV3Backup (369.07s)
=== RUN   TestAccRdsInstanceV3TemplateConfig
--- PASS: TestAccRdsInstanceV3TemplateConfig (483.48s)
=== RUN   TestAccRdsInstanceV3InvalidDBVersion
--- PASS: TestAccRdsInstanceV3InvalidDBVersion (14.13s)
=== RUN   TestAccRdsInstanceV3InvalidFlavor
--- PASS: TestAccRdsInstanceV3InvalidFlavor (14.99s)
=== RUN   TestAccRdsInstanceV3_configurationParameters
--- PASS: TestAccRdsInstanceV3_configurationParameters (379.67s)
FAIL


Process finished with the exit code 0

@anton-sidelnikov
Copy link
Member Author

basic test failed, investigating

@anton-sidelnikov
Copy link
Member Author

=== RUN TestAccRdsInstanceV3Basic
--- PASS: TestAccRdsInstanceV3Basic (518.60s)
PASS

@anton-sidelnikov anton-sidelnikov self-assigned this Aug 15, 2022
@anton-sidelnikov anton-sidelnikov added this to In progress in Upstream via automation Aug 15, 2022
outcatcher
outcatcher approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok 🙂

@anton-sidelnikov anton-sidelnikov added gate Merge PR and removed gate Merge PR labels Aug 15, 2022
@anton-sidelnikov anton-sidelnikov mentioned this pull request Aug 15, 2022
Closed
32 tasks
@otc-zuul
Copy link

otc-zuul bot commented Aug 15, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/8450b6375a0646979189113d91f94dd0

✔️ build-otc-releasenotes SUCCESS in 3m 04s
✔️ otc-golangci-lint SUCCESS in 2m 52s
✔️ golang-make-test SUCCESS in 3m 20s
✔️ golang-make-vet SUCCESS in 2m 33s
✔️ tflint SUCCESS in 1m 50s
✔️ goreleaser-build SUCCESS in 7m 30s

@otc-zuul otc-zuul bot merged commit e2ac6c2 into devel Aug 15, 2022
Upstream automation moved this from In progress to Done Aug 15, 2022
@otc-zuul otc-zuul bot deleted the rds-instance-client-ctx branch August 15, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@Aloento Aloento Aloento approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@lego963 lego963 Awaiting requested review from lego963

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
enhancement gate Merge PR
Projects
Upstream
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anton-sidelnikov @outcatcher @Aloento @artem-lifshits