Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDS]: Refactoring after gophertelekomcloud update & tests fix #2029

Merged
merged 3 commits into from Dec 27, 2022
Merged

[RDS]: Refactoring after gophertelekomcloud update & tests fix #2029

merged 3 commits into from Dec 27, 2022

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Dec 26, 2022 •
edited

Summary of the Pull Request

As title says.
rds.pg.c2.medium flavor is sold out on eu-de-02 therefore either flavor had to be changed or AZ.
Fixed several outdated tests.

PR Checklist

  • Tests passed.
  • Schema updated.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccRdsReadReplicaV3Basic
--- PASS: TestAccRdsReadReplicaV3Basic (779.47s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsConfigurationV3_basic
--- PASS: TestAccRdsConfigurationV3_basic (47.32s)
=== RUN   TestAccRdsConfigurationV3_invalidDbVersion
--- PASS: TestAccRdsConfigurationV3_invalidDbVersion (4.83s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3Basic
--- PASS: TestAccRdsInstanceV3Basic (488.35s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3RestoreBackup
--- PASS: TestAccRdsInstanceV3RestoreBackup (930.17s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3ElasticIP
--- PASS: TestAccRdsInstanceV3ElasticIP (437.89s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3HA
--- PASS: TestAccRdsInstanceV3HA (359.41s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3OptionalParams
--- PASS: TestAccRdsInstanceV3OptionalParams (346.96s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3Backup
--- PASS: TestAccRdsInstanceV3Backup (348.12s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3InvalidFlavor
--- PASS: TestAccRdsInstanceV3InvalidFlavor (6.64s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3InvalidDBVersion
--- PASS: TestAccRdsInstanceV3InvalidDBVersion (6.84s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3_configurationParameters
--- PASS: TestAccRdsInstanceV3_configurationParameters (390.80s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceV3TimeZone
--- PASS: TestAccRdsInstanceV3TimeZone (375.68s)
PASS

Process finished with the exit code 0

=== RUN   TestRDSVersionsV3_basic
--- PASS: TestRDSVersionsV3_basic (24.47s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsReadReplicaV3ImportBasic
--- PASS: TestAccRdsReadReplicaV3ImportBasic (739.03s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsInstanceDataSource_basic
=== PAUSE TestAccRdsInstanceDataSource_basic
=== CONT  TestAccRdsInstanceDataSource_basic
--- PASS: TestAccRdsInstanceDataSource_basic (353.70s)
PASS

Process finished with the exit code 0

=== RUN   TestAccRdsFlavorV3DataSource_basic
--- PASS: TestAccRdsFlavorV3DataSource_basic (23.05s)
PASS

Process finished with the exit code 0

=== RUN   TestAccDataSourceRDSV3Backup_basic
--- PASS: TestAccDataSourceRDSV3Backup_basic (441.16s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Dec 26, 2022
@artem-lifshits artem-lifshits marked this pull request as ready for review December 26, 2022 22:13
lego963
lego963 previously approved these changes Dec 27, 2022
View reviewed changes
Aloento
Aloento previously approved these changes Dec 27, 2022
View reviewed changes
anton-sidelnikov
anton-sidelnikov requested changes Dec 27, 2022
View reviewed changes
opentelekomcloud/services/rds/data_source_opentelekomcloud_rds_flavors_v3.go Outdated
Comment on lines 74 to 76
VersionName: d.Get("db_version").(string),
SpecCode: d.Get("instance_mode").(string),
DatabaseName: d.Get("db_type").(string),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parametrs number changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@artem-lifshits artem-lifshits dismissed stale reviews from Aloento and lego963 via ba4a8bc December 27, 2022 09:40
@artem-lifshits artem-lifshits added the gate Merge PR label Dec 27, 2022
@otc-zuul
Copy link

otc-zuul bot commented Dec 27, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/d39d7b9a7ae740de92e0ec0c30854a78

✔️ build-otc-releasenotes SUCCESS in 3m 38s
✔️ otc-golangci-lint SUCCESS in 3m 10s
✔️ golang-make-test SUCCESS in 3m 11s
✔️ golang-make-vet SUCCESS in 2m 33s
✔️ tflint SUCCESS in 1m 55s
✔️ goreleaser-build SUCCESS in 7m 32s

@otc-zuul otc-zuul bot merged commit 9d84de5 into devel Dec 27, 2022
@otc-zuul otc-zuul bot deleted the rds_sdk_update branch December 27, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aloento Aloento Aloento approved these changes

@lego963 lego963 lego963 approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@artem-lifshits artem-lifshits

Labels
dependencies gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artem-lifshits @Aloento @lego963 @anton-sidelnikov