Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCE: Nodes extend_params volume parameter introduced #2056

Merged
merged 3 commits into from Jan 19, 2023
Merged

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Jan 19, 2023

Summary of the Pull Request

New extend_params parameter introduced for nodes/node_pools instead of extend_param.
CCE Volumes extend_param was trying to unmarshal a map of strings into a single string which lead to an error.
This change fixes this issue and unmarshals Volume structure properly.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccCCENodePoolV3ImportBasic
=== PAUSE TestAccCCENodePoolV3ImportBasic
=== CONT  TestAccCCENodePoolV3ImportBasic
=== CONT  TestAccCCENodePoolV3ImportBasic
    resource_opentelekomcloud_cce_node_pool_v3_test.go:64: Cluster is required by the test. 3 test(s) are using cluster.
=== CONT  TestAccCCENodePoolV3ImportBasic
    cluster.go:137: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:100: starting deleting shared cluster
--- PASS: TestAccCCENodePoolV3ImportBasic (827.20s)
=== RUN   TestAccCCENodePoolsV3_basic
=== PAUSE TestAccCCENodePoolsV3_basic
=== CONT  TestAccCCENodePoolsV3_basic
=== CONT  TestAccCCENodePoolsV3_basic
    resource_opentelekomcloud_cce_node_pool_v3_test.go:32: Cluster is required by the test. 1 test(s) are using cluster.
=== CONT  TestAccCCENodePoolsV3_basic
    cluster.go:49: starting creating shared cluster
2023/01/18 23:49:24 [DEBUG] Waiting for state to become: [Available]
=== CONT  TestAccCCENodePoolsV3_basic
    cluster.go:137: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:100: starting deleting shared cluster
--- PASS: TestAccCCENodePoolsV3_basic (1181.55s)
PASS

Process finished with the exit code 0


=== RUN   TestAccCCENodesV3Basic
=== PAUSE TestAccCCENodesV3Basic
=== CONT  TestAccCCENodesV3Basic
    resource_opentelekomcloud_cce_node_v3_test.go:29: Cluster is required by the test. 1 test(s) are using cluster.
=== CONT  TestAccCCENodesV3Basic
    cluster.go:49: starting creating shared cluster
2023/01/19 10:51:45 [DEBUG] Waiting for state to become: [Available]
=== CONT  TestAccCCENodesV3Basic
    cluster.go:137: Cluster is released by the test. 9 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3Basic (745.93s)
=== RUN   TestAccCCENodesV3Timeout
=== PAUSE TestAccCCENodesV3Timeout
=== CONT  TestAccCCENodesV3Timeout
    resource_opentelekomcloud_cce_node_v3_test.go:83: Cluster is required by the test. 10 test(s) are using cluster.
=== CONT  TestAccCCENodesV3Timeout
    cluster.go:137: Cluster is released by the test. 7 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3Timeout (356.54s)
=== RUN   TestAccCCENodesV3BandWidthResize
=== PAUSE TestAccCCENodesV3BandWidthResize
=== CONT  TestAccCCENodesV3BandWidthResize
    resource_opentelekomcloud_cce_node_v3_test.go:133: Cluster is required by the test. 8 test(s) are using cluster.
=== CONT  TestAccCCENodesV3BandWidthResize
    cluster.go:137: Cluster is released by the test. 5 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3BandWidthResize (1083.01s)
=== RUN   TestAccCCENodesV3_eipIds
=== PAUSE TestAccCCENodesV3_eipIds
=== CONT  TestAccCCENodesV3_eipIds
    resource_opentelekomcloud_cce_node_v3_test.go:168: Cluster is required by the test. 10 test(s) are using cluster.
=== CONT  TestAccCCENodesV3_eipIds
    cluster.go:137: Cluster is released by the test. 1 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3_eipIds (1467.64s)
=== RUN   TestAccCCENodesV3IpSetNull
=== PAUSE TestAccCCENodesV3IpSetNull
=== CONT  TestAccCCENodesV3IpSetNull
    resource_opentelekomcloud_cce_node_v3_test.go:198: Cluster is required by the test. 9 test(s) are using cluster.
=== CONT  TestAccCCENodesV3IpSetNull
    cluster.go:137: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:100: starting deleting shared cluster
--- PASS: TestAccCCENodesV3IpSetNull (1954.10s)
=== RUN   TestAccCCENodesV3IpCreate
=== PAUSE TestAccCCENodesV3IpCreate
=== CONT  TestAccCCENodesV3IpCreate
=== CONT  TestAccCCENodesV3IpCreate
    resource_opentelekomcloud_cce_node_v3_test.go:231: Cluster is required by the test. 2 test(s) are using cluster.
=== CONT  TestAccCCENodesV3IpCreate
    cluster.go:137: Cluster is released by the test. 2 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3IpCreate (1433.47s)
=== RUN   TestAccCCENodesV3IpWithExtendedParameters
=== PAUSE TestAccCCENodesV3IpWithExtendedParameters
=== CONT  TestAccCCENodesV3IpWithExtendedParameters
=== CONT  TestAccCCENodesV3IpWithExtendedParameters
    resource_opentelekomcloud_cce_node_v3_test.go:261: Cluster is required by the test. 5 test(s) are using cluster.
=== CONT  TestAccCCENodesV3IpWithExtendedParameters
    cluster.go:137: Cluster is released by the test. 9 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3IpWithExtendedParameters (698.45s)
=== RUN   TestAccCCENodesV3IpNulls
=== PAUSE TestAccCCENodesV3IpNulls
=== CONT  TestAccCCENodesV3IpNulls
    resource_opentelekomcloud_cce_node_v3_test.go:288: Cluster is required by the test. 6 test(s) are using cluster.
=== CONT  TestAccCCENodesV3IpNulls
    cluster.go:137: Cluster is released by the test. 4 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3IpNulls (1368.88s)
=== RUN   TestAccCCENodesV3EncryptedVolume
=== PAUSE TestAccCCENodesV3EncryptedVolume
=== CONT  TestAccCCENodesV3EncryptedVolume
    resource_opentelekomcloud_cce_node_v3_test.go:310: Cluster is required by the test. 3 test(s) are using cluster.
=== CONT  TestAccCCENodesV3EncryptedVolume
    cluster.go:137: Cluster is released by the test. 9 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3EncryptedVolume (707.57s)
=== RUN   TestAccCCENodesV3TaintsK8sTags
=== PAUSE TestAccCCENodesV3TaintsK8sTags
=== CONT  TestAccCCENodesV3TaintsK8sTags
    resource_opentelekomcloud_cce_node_v3_test.go:334: Cluster is required by the test. 7 test(s) are using cluster.
=== CONT  TestAccCCENodesV3TaintsK8sTags
    cluster.go:137: Cluster is released by the test. 8 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3TaintsK8sTags (1037.79s)
=== RUN   TestAccCCENodesV3_extendParams
=== PAUSE TestAccCCENodesV3_extendParams
=== CONT  TestAccCCENodesV3_extendParams
=== CONT  TestAccCCENodesV3_extendParams
    resource_opentelekomcloud_cce_node_v3_test.go:362: Cluster is required by the test. 4 test(s) are using cluster.
=== CONT  TestAccCCENodesV3_extendParams
    cluster.go:137: Cluster is released by the test. 9 test(s) are still using cluster.
--- PASS: TestAccCCENodesV3_extendParams (696.74s)
=== RUN   TestAccCCENodesV3Multiple
=== PAUSE TestAccCCENodesV3Multiple
=== CONT  TestAccCCENodesV3Multiple
    resource_opentelekomcloud_cce_node_v3_test.go:64: Cluster is required by the test. 1 test(s) are using cluster.
    cluster.go:49: starting creating shared cluster
2023/01/19 12:20:07 [DEBUG] Waiting for state to become: [Available]
    cluster.go:137: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:100: starting deleting shared cluster
--- PASS: TestAccCCENodesV3Multiple (836.31s)
=== RUN   TestAccCCENodesV3OS
=== PAUSE TestAccCCENodesV3OS
=== CONT  TestAccCCENodesV3OS
    resource_opentelekomcloud_cce_node_v3_test.go:106: Cluster is required by the test. 1 test(s) are using cluster.
    cluster.go:49: starting creating shared cluster
2023/01/19 13:16:38 [DEBUG] Waiting for state to become: [Available]
    cluster.go:137: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:100: starting deleting shared cluster
--- PASS: TestAccCCENodesV3OS (785.00s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits marked this pull request as ready for review January 19, 2023 11:11
@artem-lifshits artem-lifshits added the gate Merge PR label Jan 19, 2023
@otc-zuul
Copy link

otc-zuul bot commented Jan 19, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/da328805513d4517b5b6de9ec0cf9031

✔️ build-otc-releasenotes SUCCESS in 3m 35s
✔️ otc-golangci-lint SUCCESS in 3m 12s
✔️ golang-make-test SUCCESS in 3m 49s
✔️ golang-make-vet SUCCESS in 2m 52s
✔️ tflint SUCCESS in 1m 41s
✔️ goreleaser-build SUCCESS in 7m 35s

@otc-zuul otc-zuul bot merged commit ee8340b into devel Jan 19, 2023
@otc-zuul otc-zuul bot deleted the cce_node_fix branch January 19, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants