Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDS: Tags management fix #2060

Merged
merged 2 commits into from Jan 24, 2023
Merged

DDS: Tags management fix #2060

merged 2 commits into from Jan 24, 2023

Conversation

artem-lifshits
Copy link
Member

Summary of the Pull Request

Fixed feature to create/change/delete tags for opentelekomcloud_dds_instance_v3.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccDDSV3Instance_single
--- PASS: TestAccDDSV3Instance_single (288.56s)
=== RUN   TestAccDDSInstanceV3_importBasic
--- PASS: TestAccDDSInstanceV3_importBasic (505.72s)
=== RUN   TestAccDDSV3Instance_minConfig
--- PASS: TestAccDDSV3Instance_minConfig (497.25s)
=== RUN   TestAccDDSV3Instance_basic
--- PASS: TestAccDDSV3Instance_basic (1538.13s)
=== RUN   TestAccDDSV3Instance_Cluster
--- PASS: TestAccDDSV3Instance_Cluster (3679.37s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Jan 23, 2023
@artem-lifshits artem-lifshits marked this pull request as ready for review January 23, 2023 15:11
@artem-lifshits artem-lifshits added the gate Merge PR label Jan 24, 2023
@otc-zuul
Copy link

otc-zuul bot commented Jan 24, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/5c6abd0e619240c287afdc43a5984d86

✔️ build-otc-releasenotes SUCCESS in 3m 20s
✔️ otc-golangci-lint SUCCESS in 2m 55s
✔️ golang-make-test SUCCESS in 3m 44s
✔️ golang-make-vet SUCCESS in 2m 34s
✔️ tflint SUCCESS in 1m 56s
✔️ goreleaser-build SUCCESS in 7m 31s

@otc-zuul otc-zuul bot merged commit 0858ad4 into devel Jan 24, 2023
@otc-zuul otc-zuul bot deleted the dds_tags branch January 24, 2023 10:17
bakhterets
bakhterets reviewed Jan 24, 2023
View reviewed changes
Copy link

@bakhterets bakhterets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakhterets bakhterets bakhterets left review comments

@Aloento Aloento Aloento approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@artem-lifshits artem-lifshits

Labels
dependencies documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artem-lifshits @Aloento @bakhterets @anton-sidelnikov