Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DWS] add resource/opentelekomcloud_dws_cluster_v1.go #2061

Merged
merged 5 commits into from Jan 26, 2023
Merged

[DWS] add resource/opentelekomcloud_dws_cluster_v1.go #2061

merged 5 commits into from Jan 26, 2023

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jan 25, 2023 •
edited

Summary of the Pull Request

New resource opentelekomcloud_dws_cluster_v1

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccDwsClusterV1_basic
=== PAUSE TestAccDwsClusterV1_basic
=== CONT  TestAccDwsClusterV1_basic
--- PASS: TestAccDwsClusterV1_basic (702.69s)
PASS


Debugger finished with the exit code 0

@anton-sidelnikov anton-sidelnikov self-assigned this Jan 25, 2023
@anton-sidelnikov anton-sidelnikov marked this pull request as ready for review January 26, 2023 11:22
Aloento
Aloento previously approved these changes Jan 26, 2023
View reviewed changes
vladimirvshivkov
vladimirvshivkov reviewed Jan 26, 2023
View reviewed changes
opentelekomcloud/acceptance/dws/resource_opentelekomcloud_dws_cluster_v1_test.go Outdated
// Config: testAccDwsV1ClusterUpdated(clusterName),
// Check: resource.ComposeTestCheckFunc(
// resource.TestCheckResourceAttr(resourceInstanceName, "name", clusterName),
// resource.TestCheckResourceAttr(resourceInstanceName, "number_of_node", "6"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncommented, it is working but not often

Aloento
Aloento previously approved these changes Jan 26, 2023
View reviewed changes
@otc-zuul
Copy link

otc-zuul bot commented Jan 26, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/444c04f16f2341d296a1f918f4a4d099

✔️ build-otc-releasenotes SUCCESS in 3m 41s
✔️ otc-golangci-lint SUCCESS in 3m 21s
✔️ golang-make-test SUCCESS in 4m 11s
✔️ golang-make-vet SUCCESS in 2m 43s
✔️ tflint SUCCESS in 2m 16s
✔️ goreleaser-build SUCCESS in 8m 17s

@otc-zuul otc-zuul bot merged commit 9ac990c into devel Jan 26, 2023
@otc-zuul otc-zuul bot deleted the dws-cluster branch January 26, 2023 13:29
bakhterets
bakhterets reviewed Feb 2, 2023
View reviewed changes
Copy link

@bakhterets bakhterets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirvshivkov vladimirvshivkov vladimirvshivkov left review comments

@bakhterets bakhterets bakhterets left review comments

@Aloento Aloento Aloento approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
dependencies documentation enhancement gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anton-sidelnikov @Aloento @vladimirvshivkov @bakhterets @artem-lifshits