Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DMS]: Fix retention time validation for opentelekomcloud_dms_topic_v1 #2066

Merged
merged 2 commits into from Feb 2, 2023
Merged

[DMS]: Fix retention time validation for opentelekomcloud_dms_topic_v1 #2066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48c1e57
[DMS]: Fix retention time validation for `opentelekomcloud_dms_topic_v1`
Feb 1, 2023
393c5c4
reno
Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/dms_topic_v1.md
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@ The following arguments are supported:
Otherwise, this parameter does not take effect.

* `retention_time` - (Required) Indicates the retention period of a message. Its default value is `72`.
Value range: `1–168`. Default value: `72`. Unit: `hour`.
Value range: `1–720`. Default value: `72`. Unit: `hour`.

* `sync_message_flush` - (Optional) Indicates whether to enable synchronous flushing.
Default value: `false`. Synchronous flushing compromises performance.
Expand Down
2 changes: 1 addition & 1 deletion opentelekomcloud/acceptance/dms/resource_opentelekomcloud_dms_topic_v1_test.go
View file
Open in desktop
Expand Up @@ -111,6 +111,6 @@ resource "opentelekomcloud_dms_topic_v1" "topic_1" {
partition = 10
replication = 2
sync_replication = true
retention_time = 80
retention_time = 720
}`, common.DataSourceSecGroupDefault, common.DataSourceSubnet, instanceName, topicName)
}
2 changes: 1 addition & 1 deletion opentelekomcloud/services/dms/resource_opentelekomcloud_dms_topic_v1.go
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@ func ResourceDmsTopicsV1() *schema.Resource {
Optional: true,
Computed: true,
ForceNew: true,
ValidateFunc: validation.IntBetween(1, 168),
ValidateFunc: validation.IntBetween(1, 720),
},
"sync_message_flush": {
Type: schema.TypeBool,
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/dms_retention-e84bc66cfe98c646.yaml
View file
Open in desktop
@@ -0,0 +1,4 @@
---
fixes:
- |
**[DMS]** Fix `retention_time` validation for ``resource/opentelekomcloud_dms_topic_v1`` (`#2066 <https://github.com/opentelekomcloud/terraform-provider-opentelekomcloud/pull/2066>`_)