Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VPC]: fix port ranges for opentelekomcloud_networking_secgroup_rule_v2 #2175

Merged
merged 2 commits into from May 16, 2023

Conversation

artem-lifshits
Copy link
Member

Summary of the Pull Request

Port ranges were set every time even if they weren't provided by the user. This happened due to terraform being unable to differentiate empty parameter from zero value provided in config.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccNetworkingV2SecGroupRule_basic
=== PAUSE TestAccNetworkingV2SecGroupRule_basic
=== CONT  TestAccNetworkingV2SecGroupRule_basic
--- PASS: TestAccNetworkingV2SecGroupRule_basic (42.93s)
=== RUN   TestAccNetworkingV2SecGroupRule_importBasic
=== PAUSE TestAccNetworkingV2SecGroupRule_importBasic
=== CONT  TestAccNetworkingV2SecGroupRule_importBasic
--- PASS: TestAccNetworkingV2SecGroupRule_importBasic (47.87s)
=== RUN   TestAccNetworkingV2SecGroupRule_timeout
=== PAUSE TestAccNetworkingV2SecGroupRule_timeout
=== CONT  TestAccNetworkingV2SecGroupRule_timeout
--- PASS: TestAccNetworkingV2SecGroupRule_timeout (42.56s)
=== RUN   TestAccNetworkingV2SecGroupRule_numericProtocol
=== PAUSE TestAccNetworkingV2SecGroupRule_numericProtocol
=== CONT  TestAccNetworkingV2SecGroupRule_numericProtocol
--- PASS: TestAccNetworkingV2SecGroupRule_numericProtocol (42.87s)
=== RUN   TestAccNetworkingV2SecGroupRule_noPorts
=== PAUSE TestAccNetworkingV2SecGroupRule_noPorts
=== CONT  TestAccNetworkingV2SecGroupRule_noPorts
--- PASS: TestAccNetworkingV2SecGroupRule_noPorts (42.17s)
=== RUN   TestAccNetworkingV2SecGroupRule_ICMP
=== PAUSE TestAccNetworkingV2SecGroupRule_ICMP
=== CONT  TestAccNetworkingV2SecGroupRule_ICMP
--- PASS: TestAccNetworkingV2SecGroupRule_ICMP (42.92s)
=== RUN   TestAccNetworkingV2SecGroupRule_noProtocolError
--- PASS: TestAccNetworkingV2SecGroupRule_noProtocolError (3.65s)
PASS

Process finished with the exit code 0

artem_lifshits added 2 commits May 16, 2023 13:34
@artem-lifshits artem-lifshits marked this pull request as ready for review May 16, 2023 13:22
@vladimirvshivkov vladimirvshivkov added the gate Merge PR label May 16, 2023
@otc-zuul
Copy link

otc-zuul bot commented May 16, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/f5dd569409b94c0cbc41289d1a692449

✔️ build-otc-releasenotes SUCCESS in 3m 24s
✔️ otc-golangci-lint SUCCESS in 2m 59s
✔️ golang-make-test SUCCESS in 3m 20s
✔️ golang-make-vet SUCCESS in 2m 46s
✔️ tflint SUCCESS in 1m 57s
✔️ goreleaser-build SUCCESS in 7m 53s

@otc-zuul otc-zuul bot merged commit 0a17c34 into devel May 16, 2023
3 checks passed
@otc-zuul otc-zuul bot deleted the vpc_sg_fix branch May 16, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants