Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDS]: Fix floating IP attachment for RDSv3 instance #2304

Merged
merged 2 commits into from Sep 12, 2023
Merged

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Sep 12, 2023

Summary of the Pull Request

Fix floating IP assignment for RDSv3 instances in rare cases when port.FixedIPs is empty.

PR Checklist

  • Tests added/passed.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccRdsInstanceV3ElasticIP
--- PASS: TestAccRdsInstanceV3ElasticIP (780.88s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Sep 12, 2023
@artem-lifshits artem-lifshits added the gate Merge PR label Sep 12, 2023
@otc-zuul
Copy link

otc-zuul bot commented Sep 12, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/08a4571cf2a0489f9fa9f65fac6ebcd1

✔️ build-otc-releasenotes SUCCESS in 4m 45s
✔️ otc-golangci-lint SUCCESS in 3m 20s
✔️ golang-make-test SUCCESS in 4m 35s
✔️ golang-make-vet SUCCESS in 3m 47s
✔️ tflint SUCCESS in 2m 28s
✔️ goreleaser-build SUCCESS in 7m 06s

@otc-zuul otc-zuul bot merged commit 1c3b110 into devel Sep 12, 2023
3 checks passed
@otc-zuul otc-zuul bot deleted the rds_port_fix branch September 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants