Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VPC]: opentelekomcloud_networking_router_route_v2 refactor & deprecation message #2328

Merged
merged 2 commits into from Oct 4, 2023
Merged

[VPC]: opentelekomcloud_networking_router_route_v2 refactor & deprecation message #2328

merged 2 commits into from Oct 4, 2023

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Oct 4, 2023 •
edited

Summary of the Pull Request

Small refactoring for opentelekomcloud_networking_router_route_v2 and deprecation message added.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccNetworkingV2RouterRoute_basic
=== PAUSE TestAccNetworkingV2RouterRoute_basic
=== CONT  TestAccNetworkingV2RouterRoute_basic
--- PASS: TestAccNetworkingV2RouterRoute_basic (131.32s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Oct 4, 2023
@artem-lifshits artem-lifshits marked this pull request as ready for review October 4, 2023 10:42
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Oct 4, 2023
@otc-zuul
Copy link

otc-zuul bot commented Oct 4, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/5115500f6e344df7986f8465fbd34f5b

✔️ build-otc-releasenotes SUCCESS in 4m 45s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 23s
✔️ golang-make-test SUCCESS in 4m 55s
✔️ golang-make-vet SUCCESS in 3m 26s
✔️ tflint SUCCESS in 3m 31s
✔️ goreleaser-build SUCCESS in 6m 58s

@otc-zuul otc-zuul bot merged commit b2ac85f into devel Oct 4, 2023
3 checks passed
@otc-zuul otc-zuul bot deleted the router_route branch October 4, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aloento Aloento Aloento approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

@Polina-Gubina Polina-Gubina Awaiting requested review from Polina-Gubina

Assignees

@artem-lifshits artem-lifshits

Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artem-lifshits @Aloento @anton-sidelnikov