Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCE] skip predefined taints for resource/opentelekomcloud_cce_node_v3 #2380

Merged

Conversation

Nemental
Copy link
Contributor

@Nemental Nemental commented Nov 28, 2023

Summary of the Pull Request

If CCE nodes are stopped and you're running terraform apply/plan, two taints will give you a "force replacement".

  # opentelekomcloud_cce_node_v3.node-1 must be replaced
-/+ resource "opentelekomcloud_cce_node_v3" "node-1" {

...

      - taints { # forces replacement
          - effect = "NoSchedule" -> null
          - key    = "node.kubernetes.io/unreachable" -> null
        }
      - taints { # forces replacement
          - effect = "NoSchedule" -> null
          - key    = "node.cloudprovider.kubernetes.io/shutdown" -> null
        }
    }

PR Checklist

  • Refers to: #xxx
  • Tests added/passed.
  • Documentation updated.
  • Schema updated.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccCCENodesV3Basic
=== PAUSE TestAccCCENodesV3Basic
=== CONT  TestAccCCENodesV3Basic
--- PASS: TestAccCCENodesV3Basic (4276.41s)
=== RUN   TestAccCCENodesV3Agency
=== PAUSE TestAccCCENodesV3Agency
=== CONT  TestAccCCENodesV3Agency
--- PASS: TestAccCCENodesV3Agency (1307.36s)
=== RUN   TestAccCCENodesV3Multiple
=== PAUSE TestAccCCENodesV3Multiple
=== CONT  TestAccCCENodesV3Multiple
--- PASS: TestAccCCENodesV3Multiple (5339.57s)
=== RUN   TestAccCCENodesV3Timeout
=== PAUSE TestAccCCENodesV3Timeout
=== CONT  TestAccCCENodesV3Timeout
--- PASS: TestAccCCENodesV3Timeout (1387.04s)
=== RUN   TestAccCCENodesV3BandWidthResize
=== PAUSE TestAccCCENodesV3BandWidthResize
=== CONT  TestAccCCENodesV3BandWidthResize
--- PASS: TestAccCCENodesV3BandWidthResize (1483.01s)
=== RUN   TestAccCCENodesV3_eipIds
=== PAUSE TestAccCCENodesV3_eipIds
=== CONT  TestAccCCENodesV3_eipIds
--- PASS: TestAccCCENodesV3_eipIds (2329.20s)
=== RUN   TestAccCCENodesV3IpSetNull
=== PAUSE TestAccCCENodesV3IpSetNull
=== CONT  TestAccCCENodesV3IpSetNull
--- PASS: TestAccCCENodesV3IpSetNull (1899.44s)
=== RUN   TestAccCCENodesV3IpCreate
=== PAUSE TestAccCCENodesV3IpCreate
=== CONT  TestAccCCENodesV3IpCreate
--- PASS: TestAccCCENodesV3IpCreate (1695.46s)
=== RUN   TestAccCCENodesV3IpNulls
=== PAUSE TestAccCCENodesV3IpNulls
=== CONT  TestAccCCENodesV3IpNulls
--- PASS: TestAccCCENodesV3IpNulls (1022.68s)
=== RUN   TestAccCCENodesV3EncryptedVolume
=== PAUSE TestAccCCENodesV3EncryptedVolume
=== CONT  TestAccCCENodesV3EncryptedVolume
--- PASS: TestAccCCENodesV3EncryptedVolume (1336.78s)
=== RUN   TestAccCCENodesV3TaintsK8sTags
=== PAUSE TestAccCCENodesV3TaintsK8sTags
=== CONT  TestAccCCENodesV3TaintsK8sTags
--- PASS: TestAccCCENodesV3TaintsK8sTags (1341.82s)
=== RUN   TestAccCCENodesV3_extendParams
=== PAUSE TestAccCCENodesV3_extendParams
=== CONT  TestAccCCENodesV3_extendParams
--- PASS: TestAccCCENodesV3_extendParams (1349.84s)
PASS

Process finished with exit code 0

@Nemental Nemental changed the title [CCE] skip predefined taints for nodes [CCE] skip predefined taints for resource_opentelekomcloud_cce_node_v3 Nov 28, 2023
@Nemental Nemental changed the title [CCE] skip predefined taints for resource_opentelekomcloud_cce_node_v3 [CCE] skip predefined taints for resource/opentelekomcloud_cce_node_v3 Nov 28, 2023
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Nov 30, 2023
Copy link

otc-zuul bot commented Nov 30, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/d5533b73f2ba42919d6e762424503768

✔️ build-otc-releasenotes SUCCESS in 5m 28s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 2m 59s
✔️ golang-make-test SUCCESS in 5m 10s
✔️ golang-make-vet SUCCESS in 3m 51s
✔️ tflint SUCCESS in 3m 15s
✔️ goreleaser-build SUCCESS in 7m 24s
✔️ otc-terraform-visualize-main SUCCESS in 6m 39s

@otc-zuul otc-zuul bot merged commit 260a3d6 into opentelekomcloud:devel Nov 30, 2023
3 checks passed
@Nemental Nemental deleted the fix/devel/skip-predefined-taints branch November 30, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants