Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cce_addon_v3 documentation #2436

Merged
merged 4 commits into from Feb 13, 2024
Merged

Conversation

dombisza
Copy link
Contributor

Summary of the Pull Request

hello there,

I tried to improve the documentation of cce_addon_v3 so users have an example how to use data sources instead of hardcoded strings and versions.

proof that it works:

Terraform will perform the following actions:

  # opentelekomcloud_cce_addon_v3.autoscaler will be created
  + resource "opentelekomcloud_cce_addon_v3" "autoscaler" {
      + cluster_id       = "DELETED"
      + description      = (known after apply)
      + id               = (known after apply)
      + name             = (known after apply)
      + template_name    = "autoscaler"
      + template_version = "1.25.21"

      + values {
          + basic  = {
              + "cceEndpoint" = "https://cce.eu-de.otc.t-systems.com"
              + "ecsEndpoint" = "https://ecs.eu-de.otc.t-systems.com"
              + "region"      = "eu-de"
              + "swr_addr"    = "100.125.7.25:20202"
              + "swr_user"    = "cce-addons"
            }
          + custom = {
              + "cluster_id"                     = "DELETED"
              + "coresTotal"                     = "32000"
              + "expander"                       = "priority"
              + "logLevel"                       = "4"
              + "maxEmptyBulkDeleteFlag"         = "10"
              + "maxNodeProvisionTime"           = "15"
              + "maxNodesTotal"                  = "1000"
              + "memoryTotal"                    = "128000"
              + "scaleDownDelayAfterAdd"         = "10"
              + "scaleDownDelayAfterDelete"      = "11"
              + "scaleDownDelayAfterFailure"     = "3"
              + "scaleDownEnabled"               = "true"
              + "scaleDownUnneededTime"          = "10"
              + "scaleDownUtilizationThreshold"  = "0.5"
              + "scaleUpCpuUtilizationThreshold" = "1"
              + "scaleUpMemUtilizationThreshold" = "1"
              + "scaleUpUnscheduledPodEnabled"   = "true"
              + "scaleUpUtilizationEnabled"      = "true"
              + "tenant_id"                      = "DELETED"
              + "unremovableNodeRecheckTimeout"  = "5"
            }
          + flavor = jsonencode(
                {
                  + description = "Has only one instance"
                  + name        = "Single"
                  + replicas    = 1
                  + resources   = [
                      + {
                          + limitsCpu   = "1000m"
                          + limitsMem   = "1000Mi"
                          + name        = "autoscaler"
                          + requestsCpu = "500m"
                          + requestsMem = "500Mi"
                        },
                    ]
                }
            )
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

opentelekomcloud_cce_addon_v3.autoscaler: Creating...
opentelekomcloud_cce_addon_v3.autoscaler: Still creating... [10s elapsed]
opentelekomcloud_cce_addon_v3.autoscaler: Creation complete after 12s [id=a630c413-c98f-11ee-aaeb-02550a10003c]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

PR Checklist

  • Refers to: #xxx
  • Tests added/passed.
  • Documentation updated.
  • Schema updated.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (101.71s)
=== RUN   TestAccSomethingV0_timeout
--- PASS: TestAccSomethingV0_timeout (128.67s)
PASS

Process finished with exit code 0

@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Feb 13, 2024
Copy link

otc-zuul bot commented Feb 13, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/8e130292b6da4ccdb5d7691680592bb9

✔️ build-otc-releasenotes SUCCESS in 5m 18s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 02s
✔️ golang-make-test SUCCESS in 4m 24s
✔️ golang-make-vet SUCCESS in 3m 45s
✔️ tflint SUCCESS in 2m 47s
✔️ goreleaser-build SUCCESS in 6m 54s
✔️ otc-terraform-visualize-main SUCCESS in 6m 23s

@otc-zuul otc-zuul bot merged commit d9fb843 into opentelekomcloud:devel Feb 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants