Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract wallet and config #1411

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Extract wallet and config #1411

merged 4 commits into from
Jun 28, 2023

Conversation

camfairchild
Copy link
Collaborator

No description provided.

camfairchild and others added 3 commits June 27, 2023 00:55
* integrate openconfig progess

* add type or suppress for argparse

* use for problematic types

* fix type hints

* move test under testcase class

* move tests under testcase class

* add test for btcli with empty arguments on every command

* remove unneeded setup from test

* remove type or suppress from int

* remove to defaults test

* use dot get for prefix check

* move tests to config repo

* fix test by passing argv=[]

* use new package name

* fix name of openconfig package
* integrate openconfig progess

* add type or suppress for argparse

* use for problematic types

* fix type hints

* move test under testcase class

* move tests under testcase class

* add test for btcli with empty arguments on every command

* remove unneeded setup from test

* remove type or suppress from int

* remove to defaults test

* use dot get for prefix check

* move test to package

* move wallet mock

* move some utils to package

* move wallet to package

* move reregister to registration utils

* add mocks

* move keyfile to package

* move test to utils tests

* use different naming

* fix import

* change function name and use kwargs

* modify naming

* add is_hotkey_registered

* use new function

* fix patch

* arg is cuda (typo)

* specify reregister true

* use generate wallet

* get mock wallet during tests

* extract get ss58 format util

* remove _mock arg

* extract tests

* import from base

* use subtensor for get_balance

* use new hotkey during test

* fix mocking

* add new packages to reqs file

* use new package naming

* bump wallet dep
@camfairchild camfairchild marked this pull request as ready for review June 28, 2023 16:51
Copy link
Contributor

@ifrit98 ifrit98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ifrit98 ifrit98 merged commit 937e43f into new_staging Jun 28, 2023
0 of 3 checks passed
@camfairchild camfairchild deleted the extract_wallet_and_config branch June 28, 2023 21:12
@camfairchild camfairchild mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants