Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expands test coverage and coverts python unittest classes to pure pytest #1686

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Expands test coverage and coverts python unittest classes to pure pytest #1686

merged 9 commits into from
Feb 1, 2024

Conversation

gus-opentensor
Copy link
Collaborator

Work to support #1657.

ifrit98
ifrit98 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ifrit98 ifrit98 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love the additions.

Before we merge:

  • Did you branch off from staging?
  • Are we sure this formatting is correct?

Want to make sure this doesn't conflict with Raj's updates to btcli formatting.

Request: can you run black . to format with black?

image

@ifrit98 ifrit98 self-requested a review January 31, 2024 22:01
@ifrit98
Copy link
Contributor

ifrit98 commented Feb 1, 2024 •
edited

Ah found the black issue. It's the versioning on the .circleci/config.yml mismatched between latest in pypi.

Setting the pip install in the config to the requirements version solves this issue: pip install black==23.7.0 (Line no 31)

https://github.com/opentensor/bittensor/blob/tests/1657/expand-cov-and-pytest/.circleci/config.yml#L31

ifrit98
ifrit98 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ifrit98 ifrit98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ifrit98 ifrit98 merged commit 202a11d into staging Feb 1, 2024
9 checks passed
@unconst unconst deleted the tests/1657/expand-cov-and-pytest branch March 27, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifrit98 ifrit98 ifrit98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gus-opentensor @ifrit98